@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix dark mode for Add Auth Provider page
Summary:
Icons were hard to see. Now they are not, plus are vertically centered.
No clue if circles are a design pattern in Phorge; you are free to come up with something better.
Refs T15056
Test Plan: Go to http://phorge.localhost/auth/config/new/
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15056
Differential Revision: https://we.phorge.it/D26189
+35
-4
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => 'beb13d57',
11
11
'conpherence.pkg.js' => '020aebcf',
12
-
'core.pkg.css' => 'aaa7082d',
12
+
'core.pkg.css' => '96104c33',
13
13
'core.pkg.js' => '9250c090',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => 'abdb4fe9',
···
126
126
'rsrc/css/phui/object-item/phui-oi-color.css' => 'b517bfa0',
127
127
'rsrc/css/phui/object-item/phui-oi-drag-ui.css' => 'da15d3dc',
128
128
'rsrc/css/phui/object-item/phui-oi-flush-ui.css' => '490e2e2e',
129
-
'rsrc/css/phui/object-item/phui-oi-list-view.css' => 'fc69e136',
129
+
'rsrc/css/phui/object-item/phui-oi-list-view.css' => 'b0f5e99b',
130
130
'rsrc/css/phui/object-item/phui-oi-simple-ui.css' => '9b03a61f',
131
131
'rsrc/css/phui/phui-action-list.css' => 'b46ef6bd',
132
132
'rsrc/css/phui/phui-action-panel.css' => '88a4298b',
···
815
815
'phui-oi-color-css' => 'b517bfa0',
816
816
'phui-oi-drag-ui-css' => 'da15d3dc',
817
817
'phui-oi-flush-ui-css' => '490e2e2e',
818
-
'phui-oi-list-view-css' => 'fc69e136',
818
+
'phui-oi-list-view-css' => 'b0f5e99b',
819
819
'phui-oi-simple-ui-css' => '9b03a61f',
820
820
'phui-pager-css' => 'd022c7ad',
821
821
'phui-pinboard-view-css' => '1f08f5d8',
+1
src/applications/auth/controller/config/PhabricatorAuthNewController.php
+1
src/applications/auth/controller/config/PhabricatorAuthNewController.php
+21
-1
src/view/phui/PHUIObjectItemView.php
+21
-1
src/view/phui/PHUIObjectItemView.php
···
21
21
private $imageURI;
22
22
private $imageHref;
23
23
private $imageIcon;
24
+
private $hasSpriteImage;
24
25
private $titleText;
25
26
private $badge;
26
27
private $countdownNum;
···
178
179
179
180
public function getImageIcon() {
180
181
return $this->imageIcon;
182
+
}
183
+
184
+
/**
185
+
* @param bool $sprite
186
+
*/
187
+
public function setHasSpriteImage($sprite) {
188
+
$this->hasSpriteImage = $sprite;
189
+
return $this;
190
+
}
191
+
192
+
/**
193
+
* @return bool
194
+
*/
195
+
public function getHasSpriteImage() {
196
+
return $this->hasSpriteImage;
181
197
}
182
198
183
199
public function setCoverImage($image) {
···
673
689
),
674
690
'');
675
691
} else if ($this->getImageIcon()) {
692
+
$item_class = 'phui-oi-image-icon';
693
+
if ($this->getHasSpriteImage()) {
694
+
$item_class = $item_class.' phui-oi-with-sprite-image';
695
+
}
676
696
$image = phutil_tag(
677
697
'div',
678
698
array(
679
-
'class' => 'phui-oi-image-icon',
699
+
'class' => $item_class,
680
700
),
681
701
$this->getImageIcon());
682
702
}
+10
webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
+10
webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
···
635
635
line-height: 36px;
636
636
}
637
637
638
+
/* Set $hoverblue for auth icons to make them readable in dark mode */
639
+
.phui-oi-image-icon.phui-oi-with-sprite-image {
640
+
background-image: radial-gradient(#eceff5 0%, #eceff5 60%, transparent 65%);
641
+
margin: 10px 2px 12px;
642
+
}
643
+
644
+
.phui-icon-view.sprite-login {
645
+
margin-top: 6px;
646
+
}
647
+
638
648
.phui-oi-image {
639
649
width: 40px;
640
650
height: 40px;