recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix transcription of single-value bulk edit fields ("Assign to")

Summary: See PHI333. Some of the cleanup at the tail end of the bulk edit changes made "Assign To" stop working properly, since we don't strip the `array(...)` off the `array(PHID)` value we receive.

Test Plan:
- Used bulk editor to assign and unassign tasks (single value datasource).
- Used bulk editor to change projects (multi-value datasource).

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18975

epriestley c9df8f77 1e3d1271

+19 -7
+6 -6
resources/celerity/map.php
··· 532 532 'rsrc/js/phuix/PHUIXButtonView.js' => '8a91e1ac', 533 533 'rsrc/js/phuix/PHUIXDropdownMenu.js' => '04b2ae03', 534 534 'rsrc/js/phuix/PHUIXExample.js' => '68af71ca', 535 - 'rsrc/js/phuix/PHUIXFormControl.js' => '1dd0870c', 535 + 'rsrc/js/phuix/PHUIXFormControl.js' => '16ad6224', 536 536 'rsrc/js/phuix/PHUIXIconView.js' => 'bff6884b', 537 537 ), 538 538 'symbols' => array( ··· 884 884 'phuix-autocomplete' => 'e0731603', 885 885 'phuix-button-view' => '8a91e1ac', 886 886 'phuix-dropdown-menu' => '04b2ae03', 887 - 'phuix-form-control-view' => '1dd0870c', 887 + 'phuix-form-control-view' => '16ad6224', 888 888 'phuix-icon-view' => 'bff6884b', 889 889 'policy-css' => '957ea14c', 890 890 'policy-edit-css' => '815c66f7', ··· 995 995 'aphront-typeahead-control-css', 996 996 'phui-tag-view-css', 997 997 ), 998 + '16ad6224' => array( 999 + 'javelin-install', 1000 + 'javelin-dom', 1001 + ), 998 1002 '17bb8539' => array( 999 1003 'javelin-behavior', 1000 1004 'javelin-stratcom', ··· 1028 1032 'javelin-vector', 1029 1033 'javelin-request', 1030 1034 'javelin-uri', 1031 - ), 1032 - '1dd0870c' => array( 1033 - 'javelin-install', 1034 - 'javelin-dom', 1035 1035 ), 1036 1036 '1e911d0f' => array( 1037 1037 'javelin-stratcom',
+12
src/applications/transactions/edittype/PhabricatorPHIDListEditType.php
··· 55 55 } 56 56 } 57 57 58 + public function getTransactionValueFromBulkEdit($value) { 59 + if (!$this->getIsSingleValue()) { 60 + return $value; 61 + } 62 + 63 + if ($value) { 64 + return head($value); 65 + } 66 + 67 + return null; 68 + } 69 + 58 70 }
+1 -1
webroot/rsrc/js/phuix/PHUIXFormControl.js
··· 293 293 }, 294 294 295 295 _newPoints: function(spec) { 296 - return this._newText(); 296 + return this._newText(spec); 297 297 }, 298 298 299 299 _newText: function(spec) {