@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Minor change to suppress linter warning
Summary: Rewrite this expression so that the second parameter to `qsprintf` is a scalar.
Test Plan: `arc lint`
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11913
+5
-5
+5
-5
src/applications/feed/query/PhabricatorFeedQuery.php
+5
-5
src/applications/feed/query/PhabricatorFeedQuery.php
···
83
83
}
84
84
85
85
private function buildGroupClause(AphrontDatabaseConnection $conn_r) {
86
-
return qsprintf(
87
-
$conn_r,
88
-
'GROUP BY '.($this->filterPHIDs
89
-
? 'ref.chronologicalKey'
90
-
: 'story.chronologicalKey'));
86
+
if ($this->filterPHIDs) {
87
+
return qsprintf($conn_r, 'GROUP BY ref.chronologicalKey');
88
+
} else {
89
+
return qsprintf($conn_r, 'GROUP BY story.chronologicalKey');
90
+
}
91
91
}
92
92
93
93
protected function getPagingColumn() {