@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Releeph project creation crumb generation
Summary: Ref T3657. We currently try to generate a project crumb on the "Create Project" page, but fail. Paper that over until I can sort out T3657.
Test Plan: Loaded project create page.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T3657
Differential Revision: https://secure.phabricator.com/D6793
+15
-8
+15
-8
src/applications/releeph/controller/ReleephProjectController.php
+15
-8
src/applications/releeph/controller/ReleephProjectController.php
···
127
127
protected function buildApplicationCrumbs() {
128
128
$crumbs = parent::buildApplicationCrumbs();
129
129
130
-
$project = $this->getReleephProject();
131
-
$project_id = $project->getID();
132
-
$project_uri = $this->getApplicationURI("project/{$project_id}/");
130
+
// TODO: The massive amount of derps here should be fixed once URIs get
131
+
// sorted out; see T3657.
133
132
134
-
$crumbs->addCrumb(
135
-
id(new PhabricatorCrumbView())
136
-
->setHref($project_uri)
137
-
->setName($project->getName()));
133
+
try {
134
+
$project = $this->getReleephProject();
135
+
$project_id = $project->getID();
136
+
$project_uri = $this->getApplicationURI("project/{$project_id}/");
137
+
138
+
$crumbs->addCrumb(
139
+
id(new PhabricatorCrumbView())
140
+
->setHref($project_uri)
141
+
->setName($project->getName()));
142
+
} catch (Exception $ex) {
143
+
// TODO: This is derps.
144
+
}
138
145
139
146
try {
140
147
$branch = $this->getReleephBranch();
···
144
151
->setHref($branch_uri)
145
152
->setName($branch->getDisplayNameWithDetail()));
146
153
} catch (Exception $ex) {
147
-
// TODO: This is kind of derps.
154
+
// TODO: This is also derps.
148
155
}
149
156
150
157
return $crumbs;