@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue where email is overquoted when attaching objects
Summary:
Currently, if you attach a revision to a task and the revision has a title with quotes or angle brackets in it, they are over-escaped in the email.
Instead, don't do that.
Test Plan: Attached `"QUOTES" MATH: 1 < 2` to a task, got a reasonable looking email.
Reviewers: btrahan, chad
Reviewed By: chad
CC: aran
Differential Revision: https://secure.phabricator.com/D7186
+6
-2
+6
-2
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+6
-2
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
···
190
190
if ($this->renderingTarget == self::TARGET_HTML) {
191
191
return $this->getHandle($phid)->renderLink();
192
192
} else {
193
-
return hsprintf('%s', $this->getHandle($phid)->getLinkName());
193
+
return $this->getHandle($phid)->getLinkName();
194
194
}
195
195
}
196
196
···
199
199
foreach ($phids as $phid) {
200
200
$links[] = $this->renderHandleLink($phid);
201
201
}
202
-
return phutil_implode_html(', ', $links);
202
+
if ($this->renderingTarget == self::TARGET_HTML) {
203
+
return phutil_implode_html(', ', $links);
204
+
} else {
205
+
return implode(', ', $links);
206
+
}
203
207
}
204
208
205
209
public function renderPolicyName($phid) {