@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When removing project slugs, try to remove raw slugs too so we can remove old/invalid slugs
Summary:
Ref T10168. When we try to remove an additional hashtag, we remove the normalized version.
Instead, remove both the literal and normalized versions. This allows us to remove old/invalid slugs.
Test Plan: Removed garbage slugs like `[,*,]`.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10168
Differential Revision: https://secure.phabricator.com/D15048
+7
-2
+7
-2
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+7
-2
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
···
756
756
}
757
757
758
758
private function removeSlugs(PhabricatorProject $project, array $slugs) {
759
-
$slugs = $this->normalizeSlugs($slugs);
760
-
761
759
if (!$slugs) {
762
760
return;
761
+
}
762
+
763
+
// We're going to try to delete both the literal and normalized versions
764
+
// of all slugs. This allows us to destroy old slugs that are no longer
765
+
// valid.
766
+
foreach ($this->normalizeSlugs($slugs) as $slug) {
767
+
$slugs[] = $slug;
763
768
}
764
769
765
770
$objects = id(new PhabricatorProjectSlug())->loadAllWhere(