recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Dashboard Tabs: render "Move" buttons grayed out more consistently

Summary:
If you happen to create a Dashboard by retrieving other people's panels,
you were probably affected by this visual bug.

It seems that you cannot Move things, but you really can (and that is OK).

The reason is, to move things in a Parent Panel, you only need edit permission there,
and you do not need to also have edit permissions on every Child Panel.

Closes T15492

Test Plan:
- From user A:
- Create two panels - editable by: User A
- From user B:
- Create a "Tabs Panel" in a Dashboard
- Attach the panels from User A (so, editable by, not you)

The meaningful "Move" actions should be not disabled anymore.

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15492

Differential Revision: https://we.phorge.it/D25308

Valerio Bozzolan cae12463 b3ac5ceb

+2 -2
+2 -2
src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
··· 181 181 ->setIcon('fa-chevron-left') 182 182 ->setHref($prev_uri) 183 183 ->setWorkflow(true) 184 - ->setDisabled(($prev_key === null) || !$can_edit)); 184 + ->setDisabled($prev_key === null)); 185 185 186 186 $dropdown_menu->addAction( 187 187 id(new PhabricatorActionView()) ··· 189 189 ->setIcon('fa-chevron-right') 190 190 ->setHref($next_uri) 191 191 ->setWorkflow(true) 192 - ->setDisabled(($next_key === null) || !$can_edit)); 192 + ->setDisabled($next_key === null)); 193 193 194 194 $dropdown_menu->addAction( 195 195 id(new PhabricatorActionView())