@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use "tag" more consistenty when referring to associating a project with an object
Summary:
Ref T10144. This isn't comprehensive, but we can give it a try and see how it feels?
- EditEngine forms now say "Tags" instead of "Projects".
- Modern SearchEngine forms now say "Tags" instead of "Projects".
- For clarity, replaced as much "in project" language as I could find with "tagged with project" language.
Test Plan: reading / grepping + used "not tagged with any project" token
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10144
Differential Revision: https://secure.phabricator.com/D15108
+24
-22
+1
-1
src/applications/home/controller/PhabricatorHomeMainController.php
+1
-1
src/applications/home/controller/PhabricatorHomeMainController.php
···
190
190
if (!$tasks) {
191
191
return $this->renderMiniPanel(
192
192
pht('No "Needs Triage" Tasks'),
193
-
pht('No tasks in projects you are a member of need triage.'));
193
+
pht('No tasks tagged with projects you are a member of need triage.'));
194
194
}
195
195
196
196
$title = pht('Needs Triage');
+5
-4
src/applications/maniphest/query/ManiphestTaskQuery.php
+5
-4
src/applications/maniphest/query/ManiphestTaskQuery.php
···
278
278
279
279
foreach ($tasks as $key => $task) {
280
280
if (!$task->getGroupByProjectPHID()) {
281
-
// This task is either not in any projects, or only in projects
282
-
// which we're ignoring because they're being queried for explicitly.
281
+
// This task is either not tagged with any projects, or only tagged
282
+
// with projects which we're ignoring because they're being queried
283
+
// for explicitly.
283
284
continue;
284
285
}
285
286
···
642
643
* Return project PHIDs which we should ignore when grouping tasks by
643
644
* project. For example, if a user issues a query like:
644
645
*
645
-
* Tasks in all projects: Frontend, Bugs
646
+
* Tasks tagged with all projects: Frontend, Bugs
646
647
*
647
648
* ...then we don't show "Frontend" or "Bugs" groups in the result set, since
648
649
* they're meaningless as all results are in both groups.
649
650
*
650
651
* Similarly, for queries like:
651
652
*
652
-
* Tasks in any projects: Public Relations
653
+
* Tasks tagged with any projects: Public Relations
653
654
*
654
655
* ...we ignore the single project, as every result is in that project. (In
655
656
* the case that there are several "any" projects, we do not ignore them.)
+7
-7
src/applications/project/engineextension/PhabricatorProjectsEditEngineExtension.php
+7
-7
src/applications/project/engineextension/PhabricatorProjectsEditEngineExtension.php
···
44
44
45
45
$projects_field = id(new PhabricatorProjectsEditField())
46
46
->setKey('projectPHIDs')
47
-
->setLabel(pht('Projects'))
47
+
->setLabel(pht('Tags'))
48
48
->setEditTypeKey('projects')
49
-
->setAliases(array('project', 'projects'))
49
+
->setAliases(array('project', 'projects', 'tag', 'tags'))
50
50
->setIsCopyable(true)
51
51
->setUseEdgeTransactions(true)
52
-
->setCommentActionLabel(pht('Change Projects'))
53
-
->setDescription(pht('Select projects for the object.'))
52
+
->setCommentActionLabel(pht('Change Project Tags'))
53
+
->setDescription(pht('Select project tags for the object.'))
54
54
->setTransactionType($edge_type)
55
55
->setMetadataValue('edge:type', $project_edge_type)
56
56
->setValue($project_phids);
···
58
58
$projects_field->setViewer($engine->getViewer());
59
59
60
60
$edit_add = $projects_field->getConduitEditType('projects.add')
61
-
->setConduitDescription(pht('Add projects.'));
61
+
->setConduitDescription(pht('Add project tags.'));
62
62
63
63
$edit_set = $projects_field->getConduitEditType('projects.set')
64
64
->setConduitDescription(
65
-
pht('Set projects, overwriting current value.'));
65
+
pht('Set project tags, overwriting current value.'));
66
66
67
67
$edit_rem = $projects_field->getConduitEditType('projects.remove')
68
-
->setConduitDescription(pht('Remove projects.'));
68
+
->setConduitDescription(pht('Remove project tags.'));
69
69
70
70
return array(
71
71
$projects_field,
+3
-3
src/applications/project/engineextension/PhabricatorProjectsSearchEngineExtension.php
+3
-3
src/applications/project/engineextension/PhabricatorProjectsSearchEngineExtension.php
···
41
41
$fields[] = id(new PhabricatorProjectSearchField())
42
42
->setKey('projectPHIDs')
43
43
->setConduitKey('projects')
44
-
->setAliases(array('project', 'projects'))
45
-
->setLabel(pht('Projects'))
44
+
->setAliases(array('project', 'projects', 'tag', 'tags'))
45
+
->setLabel(pht('Tags'))
46
46
->setDescription(
47
-
pht('Search for objects associated with given projects.'));
47
+
pht('Search for objects tagged with given projects.'));
48
48
49
49
return $fields;
50
50
}
+7
-6
src/applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php
+7
-6
src/applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php
···
4
4
extends PhabricatorTypeaheadDatasource {
5
5
6
6
public function getBrowseTitle() {
7
-
return pht('Browse Not In Any Projects');
7
+
return pht('Browse Not Tagged With Any Projects');
8
8
}
9
9
10
10
public function getPlaceholderText() {
11
-
return pht('Type "not in any projects"...');
11
+
return pht('Type "not tagged with any projects"...');
12
12
}
13
13
14
14
public function getDatasourceApplicationClass() {
···
18
18
public function getDatasourceFunctions() {
19
19
return array(
20
20
'null' => array(
21
-
'name' => pht('Not In Any Projects'),
22
-
'summary' => pht('Find results which are not in any projects.'),
21
+
'name' => pht('Not Tagged With Any Projects'),
22
+
'summary' => pht(
23
+
'Find results which are not tagged with any projects.'),
23
24
'description' => pht(
24
-
"This function matches results which are not associated with any ".
25
+
"This function matches results which are not tagged with any ".
25
26
"projects. It is usually most often used to find objects which ".
26
27
"might have slipped through the cracks and not been organized ".
27
28
"properly.\n\n%s",
···
60
61
}
61
62
62
63
private function buildNullResult() {
63
-
$name = pht('Not In Any Projects');
64
+
$name = pht('Not Tagged With Any Projects');
64
65
65
66
return $this->newFunctionResult()
66
67
->setUnique(true)
+1
-1
src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php
+1
-1
src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php