@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a possible query error in filtering events
If all events are filtered by range logic, this invitee query may be invalid.
Auditors: lpriestley
+9
-5
+9
-5
src/applications/calendar/query/PhabricatorCalendarEventQuery.php
+9
-5
src/applications/calendar/query/PhabricatorCalendarEventQuery.php
···
266
266
$phids[] = $event->getPHID();
267
267
}
268
268
269
-
$invitees = id(new PhabricatorCalendarEventInviteeQuery())
270
-
->setViewer($this->getViewer())
271
-
->withEventPHIDs($phids)
272
-
->execute();
273
-
$invitees = mgroup($invitees, 'getEventPHID');
269
+
if ($events) {
270
+
$invitees = id(new PhabricatorCalendarEventInviteeQuery())
271
+
->setViewer($this->getViewer())
272
+
->withEventPHIDs($phids)
273
+
->execute();
274
+
$invitees = mgroup($invitees, 'getEventPHID');
275
+
} else {
276
+
$invitees = array();
277
+
}
274
278
275
279
foreach ($events as $event) {
276
280
$event_invitees = idx($invitees, $event->getPHID(), array());