When queueing search index tasks, include the "objectPHID" in the task metadata

@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge

phorge phabricator

fork

Summary:
Ref T13151. See PHI719. One minor hiccup in debugging the issue (which ended up being "revision has 100K comments") was that the `SearchWorker` did not show which object it was indexing.

Add `'objectPHID'` to the queue call so you can see which object is affected from the web UI.

Test Plan:
- Stopped daemons.
- Used `bin/search index D123 --background` to queue a search task.
- Viewed task details in web UI from `/daemon/`.
- Before change: no indication of which object was being indexed.
- After change: page helpfully shows that the task is indexing D123.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13151

Differential Revision: https://secure.phabricator.com/D19502

epriestley 8 years ago cbc71e75 b1f4a974

1 changed file

expand all

src

applications

worker

PhabricatorSearchWorker.php

src/applications/search/worker/PhabricatorSearchWorker.php

··· 15 15 ), 16 16 array( 17 17 'priority' => parent::PRIORITY_IMPORT, 18 + 'objectPHID' => $phid, 18 19 )); 19 20 } 20 21

Configure Feed

Configure Feed