@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove some array typehints for passing around
Summary: See discussion at https://secure.phabricator.com/D19492#241996
Test Plan: Refreshed a few Diffusion tabs; nothing broke.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D19578
+4
-4
+3
-3
src/applications/repository/storage/PhabricatorRepositoryCommit.php
+3
-3
src/applications/repository/storage/PhabricatorRepositoryCommit.php
···
446
446
* the migration to using identities, update this method to remove the
447
447
* fallback. See T12164 for details.
448
448
*/
449
-
public function renderAnyCommitter(PhabricatorUser $viewer, array $handles) {
449
+
public function renderAnyCommitter(PhabricatorUser $viewer, $handles) {
450
450
$committer = $this->renderCommitter($viewer, $handles);
451
451
if ($committer) {
452
452
return $committer;
···
455
455
return $this->renderAuthor($viewer, $handles);
456
456
}
457
457
458
-
public function renderCommitter(PhabricatorUser $viewer, array $handles) {
458
+
public function renderCommitter(PhabricatorUser $viewer, $handles) {
459
459
$committer_phid = $this->getCommitterDisplayPHID();
460
460
if ($committer_phid) {
461
461
return $handles[$committer_phid]->renderLink();
···
470
470
return null;
471
471
}
472
472
473
-
public function renderAuthor(PhabricatorUser $viewer, array $handles) {
473
+
public function renderAuthor(PhabricatorUser $viewer, $handles) {
474
474
$author_phid = $this->getAuthorDisplayPHID();
475
475
if ($author_phid) {
476
476
return $handles[$author_phid]->renderLink();
+1
-1
src/applications/subscriptions/view/SubscriptionListDialogBuilder.php
+1
-1
src/applications/subscriptions/view/SubscriptionListDialogBuilder.php
···
58
58
->addCancelButton($object_handle->getURI(), pht('Close'));
59
59
}
60
60
61
-
private function buildBody(PhabricatorUser $viewer, array $handles) {
61
+
private function buildBody(PhabricatorUser $viewer, $handles) {
62
62
63
63
$list = id(new PHUIObjectItemListView())
64
64
->setUser($viewer);