@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't warn that workboard columns need a name when editing milestone columns
Summary: See <https://discourse.phabricator-community.org/t/columns-must-have-a-name-while-editong-point-limit-on-milestone-column/2650>. This check doesn't make sense for proxy columns, including milestone columns.
Test Plan: Added a point limit to a milestone column.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20448
+4
-1
+4
-1
src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php
+4
-1
src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php
···
41
41
if ($this->isEmptyTextTransaction($object->getName(), $xactions)) {
42
42
// The default "Backlog" column is allowed to be unnamed, which
43
43
// means we use the default name.
44
-
if (!$object->isDefaultColumn()) {
44
+
45
+
// Proxy columns can't have a name, so don't raise an error here.
46
+
47
+
if (!$object->isDefaultColumn() && !$object->getProxy()) {
45
48
$errors[] = $this->newRequiredError(
46
49
pht('Columns must have a name.'));
47
50
}