recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't compute a nonsensical assigned task count for logged-out users

Summary:
When a logged-out user views the home page, we currently compute a meaningless "assigned tasks" count which just counts every open task. Don't do this.

Ideally `ManiphestTaskQuery` should get some tightening up too (that is, `withOwners(array(null))` should not select every task), but that might affect other stuff and the performance implications of counting every open task are affecting WMF, so just fix the immediate issue for now.

Test Plan:
- Viewed homepage as a logged out user, no assigned task count.
- Viewed homepage as a logged-in user, still saw assigned task count.

Reviewers: btrahan, chad, chasemp

Reviewed By: chasemp

Subscribers: 20after4, epriestley

Differential Revision: https://secure.phabricator.com/D10876

epriestley cd406948 43508586

+4
+4
src/applications/maniphest/application/PhabricatorManiphestApplication.php
··· 75 75 public function loadStatus(PhabricatorUser $user) { 76 76 $status = array(); 77 77 78 + if (!$user->isLoggedIn()) { 79 + return $status; 80 + } 81 + 78 82 $query = id(new ManiphestTaskQuery()) 79 83 ->setViewer($user) 80 84 ->withStatuses(ManiphestTaskStatus::getOpenStatusConstants())