recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Allow users with no CAN_EDIT permissions to silence projects if they want to

Summary: Humble user cannot silence/mute project if he/she has no CAN_EDIT permissions in it. You can actually leave it but if project is locked - then you're scr*wed.

Test Plan:
1. On a testing phabricator instance created a dummy project
2. Changed that project permissions CAN_EDIT to be by admin only
3. Added poor soul with no CAN_EDIT permissions
4. Logged it in with poor soul
5. Tried to silence the project
6. The Project is successfully silenced
7. User is happy :)

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, Pawka

Differential Revision: https://secure.phabricator.com/D20675

Arturas Moskvinas cd449254 4fd473e7

+5
+5
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
··· 1801 1801 // you don't need permissions. If you can eventually mute an object 1802 1802 // for other users, this would need to be revisited. 1803 1803 return null; 1804 + case PhabricatorProjectSilencedEdgeType::EDGECONST: 1805 + // At time of writing, you can only write this edge for yourself, so 1806 + // you don't need permissions. If you can eventually silence project 1807 + // for other users, this would need to be revisited. 1808 + return null; 1804 1809 case PhabricatorObjectMentionsObjectEdgeType::EDGECONST: 1805 1810 return null; 1806 1811 case PhabricatorProjectProjectHasMemberEdgeType::EDGECONST: