recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix broken code in PhabricatorMetaMTAMail::flattenHeaders()

Summary: Looping over the elements of an empty array while ignoring the parameter passed makes no sense. Looks like a typo.

Test Plan: Run static code analysis: `/src/applications/metamta/storage/PhabricatorMetaMTAMail.php:1104 Empty array passed to foreach`

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26416

Andre Klapper cd4dd3b3 7c109c59

+1 -1
+1 -1
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
··· 1101 1101 assert_instances_of($headers, PhabricatorMailHeader::class); 1102 1102 1103 1103 $list = array(); 1104 - foreach ($list as $header) { 1104 + foreach ($headers as $header) { 1105 1105 $list[] = array( 1106 1106 $header->getName(), 1107 1107 $header->getValue(),