@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove `metamta.differential.unified-comment-context` and explain it in ExtraConfigSetupCheck
Summary: Ref T10694. This setting no longer has any effect: we always show a limited amount of context now.
Test Plan: `grep`
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10694
Differential Revision: https://secure.phabricator.com/D15886
+4
-15
+4
src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
+4
src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
···
310
310
'notification.enabled' => $aphlict_reason,
311
311
'notification.client-uri' => $aphlict_reason,
312
312
'notification.server-uri' => $aphlict_reason,
313
+
314
+
'metamta.differential.unified-comment-context' => pht(
315
+
'Inline comments are now always rendered with a limited amount '.
316
+
'of context.'),
313
317
);
314
318
315
319
return $ancient_config;
-15
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
-15
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
···
287
287
'unified')
288
288
->setDescription(
289
289
pht("Format for inlined or attached patches: 'git' or 'unified'.")),
290
-
$this->newOption(
291
-
'metamta.differential.unified-comment-context',
292
-
'bool',
293
-
false)
294
-
->setBoolOptions(
295
-
array(
296
-
pht('Show context'),
297
-
pht('Do not show context'),
298
-
))
299
-
->setSummary(pht('Show diff context around inline comments in email.'))
300
-
->setDescription(
301
-
pht(
302
-
'Normally, inline comments in emails are shown with a file and '.
303
-
'line but without any diff context. Enabling this option adds '.
304
-
'diff context and the comment thread.')),
305
290
);
306
291
}
307
292