recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

CSS Tweaks to reviewers status list

Summary: Updates the review status list to align better inside property lists. Alsu uses the default colors a bit more. This removes an overflow hidden on the value side, but that shouldnt cause any issues, given it has plenty of space.

Test Plan: tested differential and audit, highlighted and not.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7441

Chad Little cdcfbb69 62edbb8e

+54 -51
+47 -47
src/__celerity_resource_map__.php
··· 3930 3930 ), 3931 3931 'phui-property-list-view-css' => 3932 3932 array( 3933 - 'uri' => '/res/dc22cea9/rsrc/css/phui/phui-property-list-view.css', 3933 + 'uri' => '/res/b307acfe/rsrc/css/phui/phui-property-list-view.css', 3934 3934 'type' => 'css', 3935 3935 'requires' => 3936 3936 array( ··· 3957 3957 ), 3958 3958 'phui-status-list-view-css' => 3959 3959 array( 3960 - 'uri' => '/res/3410386e/rsrc/css/phui/phui-status.css', 3960 + 'uri' => '/res/868f8a95/rsrc/css/phui/phui-status.css', 3961 3961 'type' => 'css', 3962 3962 'requires' => 3963 3963 array( ··· 4318 4318 ), array( 4319 4319 'packages' => 4320 4320 array( 4321 - 'a8252666' => 4321 + 'e3e5a752' => 4322 4322 array( 4323 4323 'name' => 'core.pkg.css', 4324 4324 'symbols' => ··· 4367 4367 41 => 'phabricator-tag-view-css', 4368 4368 42 => 'phui-list-view-css', 4369 4369 ), 4370 - 'uri' => '/res/pkg/a8252666/core.pkg.css', 4370 + 'uri' => '/res/pkg/e3e5a752/core.pkg.css', 4371 4371 'type' => 'css', 4372 4372 ), 4373 4373 '2c1dba03' => ··· 4559 4559 ), 4560 4560 'reverse' => 4561 4561 array( 4562 - 'aphront-dialog-view-css' => 'a8252666', 4563 - 'aphront-error-view-css' => 'a8252666', 4564 - 'aphront-list-filter-view-css' => 'a8252666', 4565 - 'aphront-pager-view-css' => 'a8252666', 4566 - 'aphront-panel-view-css' => 'a8252666', 4567 - 'aphront-table-view-css' => 'a8252666', 4568 - 'aphront-tokenizer-control-css' => 'a8252666', 4569 - 'aphront-tooltip-css' => 'a8252666', 4570 - 'aphront-typeahead-control-css' => 'a8252666', 4562 + 'aphront-dialog-view-css' => 'e3e5a752', 4563 + 'aphront-error-view-css' => 'e3e5a752', 4564 + 'aphront-list-filter-view-css' => 'e3e5a752', 4565 + 'aphront-pager-view-css' => 'e3e5a752', 4566 + 'aphront-panel-view-css' => 'e3e5a752', 4567 + 'aphront-table-view-css' => 'e3e5a752', 4568 + 'aphront-tokenizer-control-css' => 'e3e5a752', 4569 + 'aphront-tooltip-css' => 'e3e5a752', 4570 + 'aphront-typeahead-control-css' => 'e3e5a752', 4571 4571 'differential-changeset-view-css' => '1084b12b', 4572 4572 'differential-core-view-css' => '1084b12b', 4573 4573 'differential-inline-comment-editor' => '5e9e5c4e', ··· 4581 4581 'differential-table-of-contents-css' => '1084b12b', 4582 4582 'diffusion-commit-view-css' => '270f4eb4', 4583 4583 'diffusion-icons-css' => '270f4eb4', 4584 - 'global-drag-and-drop-css' => 'a8252666', 4584 + 'global-drag-and-drop-css' => 'e3e5a752', 4585 4585 'inline-comment-summary-css' => '1084b12b', 4586 4586 'javelin-aphlict' => '2c1dba03', 4587 4587 'javelin-behavior' => '3e3be199', ··· 4656 4656 'javelin-util' => '3e3be199', 4657 4657 'javelin-vector' => '3e3be199', 4658 4658 'javelin-workflow' => '3e3be199', 4659 - 'lightbox-attachment-css' => 'a8252666', 4659 + 'lightbox-attachment-css' => 'e3e5a752', 4660 4660 'maniphest-task-summary-css' => '49898640', 4661 - 'phabricator-action-list-view-css' => 'a8252666', 4662 - 'phabricator-application-launch-view-css' => 'a8252666', 4661 + 'phabricator-action-list-view-css' => 'e3e5a752', 4662 + 'phabricator-application-launch-view-css' => 'e3e5a752', 4663 4663 'phabricator-busy' => '2c1dba03', 4664 4664 'phabricator-content-source-view-css' => '1084b12b', 4665 - 'phabricator-core-css' => 'a8252666', 4666 - 'phabricator-crumbs-view-css' => 'a8252666', 4665 + 'phabricator-core-css' => 'e3e5a752', 4666 + 'phabricator-crumbs-view-css' => 'e3e5a752', 4667 4667 'phabricator-drag-and-drop-file-upload' => '5e9e5c4e', 4668 4668 'phabricator-dropdown-menu' => '2c1dba03', 4669 4669 'phabricator-file-upload' => '2c1dba03', 4670 - 'phabricator-filetree-view-css' => 'a8252666', 4671 - 'phabricator-flag-css' => 'a8252666', 4670 + 'phabricator-filetree-view-css' => 'e3e5a752', 4671 + 'phabricator-flag-css' => 'e3e5a752', 4672 4672 'phabricator-hovercard' => '2c1dba03', 4673 - 'phabricator-jump-nav' => 'a8252666', 4673 + 'phabricator-jump-nav' => 'e3e5a752', 4674 4674 'phabricator-keyboard-shortcut' => '2c1dba03', 4675 4675 'phabricator-keyboard-shortcut-manager' => '2c1dba03', 4676 - 'phabricator-main-menu-view' => 'a8252666', 4676 + 'phabricator-main-menu-view' => 'e3e5a752', 4677 4677 'phabricator-menu-item' => '2c1dba03', 4678 - 'phabricator-nav-view-css' => 'a8252666', 4678 + 'phabricator-nav-view-css' => 'e3e5a752', 4679 4679 'phabricator-notification' => '2c1dba03', 4680 - 'phabricator-notification-css' => 'a8252666', 4681 - 'phabricator-notification-menu-css' => 'a8252666', 4680 + 'phabricator-notification-css' => 'e3e5a752', 4681 + 'phabricator-notification-menu-css' => 'e3e5a752', 4682 4682 'phabricator-object-selector-css' => '1084b12b', 4683 4683 'phabricator-phtize' => '2c1dba03', 4684 4684 'phabricator-prefab' => '2c1dba03', 4685 4685 'phabricator-project-tag-css' => '49898640', 4686 - 'phabricator-remarkup-css' => 'a8252666', 4686 + 'phabricator-remarkup-css' => 'e3e5a752', 4687 4687 'phabricator-shaped-request' => '5e9e5c4e', 4688 - 'phabricator-side-menu-view-css' => 'a8252666', 4689 - 'phabricator-standard-page-view' => 'a8252666', 4690 - 'phabricator-tag-view-css' => 'a8252666', 4688 + 'phabricator-side-menu-view-css' => 'e3e5a752', 4689 + 'phabricator-standard-page-view' => 'e3e5a752', 4690 + 'phabricator-tag-view-css' => 'e3e5a752', 4691 4691 'phabricator-textareautils' => '2c1dba03', 4692 4692 'phabricator-tooltip' => '2c1dba03', 4693 - 'phabricator-transaction-view-css' => 'a8252666', 4694 - 'phabricator-zindex-css' => 'a8252666', 4695 - 'phui-button-css' => 'a8252666', 4696 - 'phui-form-css' => 'a8252666', 4697 - 'phui-form-view-css' => 'a8252666', 4698 - 'phui-header-view-css' => 'a8252666', 4699 - 'phui-icon-view-css' => 'a8252666', 4700 - 'phui-list-view-css' => 'a8252666', 4701 - 'phui-object-item-list-view-css' => 'a8252666', 4702 - 'phui-property-list-view-css' => 'a8252666', 4703 - 'phui-spacing-css' => 'a8252666', 4704 - 'sprite-apps-large-css' => 'a8252666', 4705 - 'sprite-gradient-css' => 'a8252666', 4706 - 'sprite-icons-css' => 'a8252666', 4707 - 'sprite-menu-css' => 'a8252666', 4708 - 'sprite-status-css' => 'a8252666', 4709 - 'syntax-highlighting-css' => 'a8252666', 4693 + 'phabricator-transaction-view-css' => 'e3e5a752', 4694 + 'phabricator-zindex-css' => 'e3e5a752', 4695 + 'phui-button-css' => 'e3e5a752', 4696 + 'phui-form-css' => 'e3e5a752', 4697 + 'phui-form-view-css' => 'e3e5a752', 4698 + 'phui-header-view-css' => 'e3e5a752', 4699 + 'phui-icon-view-css' => 'e3e5a752', 4700 + 'phui-list-view-css' => 'e3e5a752', 4701 + 'phui-object-item-list-view-css' => 'e3e5a752', 4702 + 'phui-property-list-view-css' => 'e3e5a752', 4703 + 'phui-spacing-css' => 'e3e5a752', 4704 + 'sprite-apps-large-css' => 'e3e5a752', 4705 + 'sprite-gradient-css' => 'e3e5a752', 4706 + 'sprite-icons-css' => 'e3e5a752', 4707 + 'sprite-menu-css' => 'e3e5a752', 4708 + 'sprite-status-css' => 'e3e5a752', 4709 + 'syntax-highlighting-css' => 'e3e5a752', 4710 4710 ), 4711 4711 ));
+3 -3
src/applications/differential/view/DifferentialReviewersView.php
··· 43 43 44 44 switch ($reviewer->getStatus()) { 45 45 case DifferentialReviewerStatus::STATUS_ADDED: 46 - $item->setIcon('open-dark', pht('Review Requested')); 46 + $item->setIcon('open', pht('Review Requested')); 47 47 break; 48 48 49 49 case DifferentialReviewerStatus::STATUS_ACCEPTED: ··· 73 73 case DifferentialReviewerStatus::STATUS_COMMENTED: 74 74 if ($is_current) { 75 75 $item->setIcon( 76 - 'info-blue', 76 + 'info', 77 77 pht('Commented')); 78 78 } else { 79 79 $item->setIcon( ··· 87 87 break; 88 88 89 89 default: 90 - $item->setIcon('question-dark', pht('%s?', $reviewer->getStatus())); 90 + $item->setIcon('question', pht('%s?', $reviewer->getStatus())); 91 91 break; 92 92 93 93 }
-1
webroot/rsrc/css/phui/phui-property-list-view.css
··· 60 60 61 61 .phui-property-list-value { 62 62 color: {$darkgreytext}; 63 - overflow: hidden; 64 63 line-height: 17px; 65 64 } 66 65
+4
webroot/rsrc/css/phui/phui-status.css
··· 6 6 width: 100%; 7 7 } 8 8 9 + .phui-property-list-value .phui-status-list-view { 10 + margin-left: -4px; 11 + } 12 + 9 13 .phui-status-list-view .phui-icon-view { 10 14 display: block; 11 15 width: 14px;