@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Correct a case where a single-hunk diff may incorrectly be identified as multi-hunk by the Scope engine
Summary: See PHI985. The layers above this may return `array()` to mean "one hunk with a line-1 offset". Accept either `array()` or `array(1 => ...)` to engage the scope engine.
Test Plan: See PHI985.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20363
+6
-1
+6
-1
src/applications/differential/render/DifferentialChangesetRenderer.php
+6
-1
src/applications/differential/render/DifferentialChangesetRenderer.php
···
684
684
// If this change is missing context, don't try to identify scopes, since
685
685
// we won't really be able to get anywhere.
686
686
$has_multiple_hunks = (count($hunk_starts) > 1);
687
-
$has_offset_hunks = (head_key($hunk_starts) != 1);
687
+
688
+
$has_offset_hunks = false;
689
+
if ($hunk_starts) {
690
+
$has_offset_hunks = (head_key($hunk_starts) != 1);
691
+
}
692
+
688
693
$missing_context = ($has_multiple_hunks || $has_offset_hunks);
689
694
690
695
if ($missing_context) {