@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When setup issues raise opcache configuration errors, point at the opcache configuration page
Summary:
Fixes T11746. The opcache docs are on a different page, so point there if we're raising opcache issues.
(It's possible for a setup issue to say "configure X, or configure Y", where X is opcache and Y is non-opcache, so we may want to render both links.)
Test Plan: {F1867109}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11746
Differential Revision: https://secure.phabricator.com/D16685
+42
-13
+42
-13
src/applications/config/view/PhabricatorSetupIssueView.php
+42
-13
src/applications/config/view/PhabricatorSetupIssueView.php
···
404
404
implode("\n", $more_loc));
405
405
}
406
406
407
-
$info[] = phutil_tag(
408
-
'p',
409
-
array(),
410
-
pht(
411
-
'You can find more information about PHP configuration values in the '.
412
-
'%s.',
413
-
phutil_tag(
414
-
'a',
415
-
array(
416
-
'href' => 'http://php.net/manual/ini.list.php',
417
-
'target' => '_blank',
418
-
),
419
-
pht('PHP Documentation'))));
407
+
$show_standard = false;
408
+
$show_opcache = false;
409
+
410
+
foreach ($configs as $key) {
411
+
if (preg_match('/^opcache\./', $key)) {
412
+
$show_opcache = true;
413
+
} else {
414
+
$show_standard = true;
415
+
}
416
+
}
417
+
418
+
if ($show_standard) {
419
+
$info[] = phutil_tag(
420
+
'p',
421
+
array(),
422
+
pht(
423
+
'You can find more information about PHP configuration values '.
424
+
'in the %s.',
425
+
phutil_tag(
426
+
'a',
427
+
array(
428
+
'href' => 'http://php.net/manual/ini.list.php',
429
+
'target' => '_blank',
430
+
),
431
+
pht('PHP Documentation'))));
432
+
}
433
+
434
+
if ($show_opcache) {
435
+
$info[] = phutil_tag(
436
+
'p',
437
+
array(),
438
+
pht(
439
+
'You can find more information about configuring OPCache in '.
440
+
'the %s.',
441
+
phutil_tag(
442
+
'a',
443
+
array(
444
+
'href' => 'http://php.net/manual/opcache.configuration.php',
445
+
'target' => '_blank',
446
+
),
447
+
pht('PHP OPCache Documentation'))));
448
+
}
420
449
421
450
$info[] = phutil_tag(
422
451
'p',