@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
DifferentialCommentEditor::alterReviewers is now aware of differential.allow-self-accept setting
Summary: This allows users to add a revision's author as reviewer according Differential configuration using the 'Leap Into Action' form.
Test Plan: Tested on local install.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T1885
Differential Revision: https://secure.phabricator.com/D3682
authored by
Dereckson
and committed by
epriestley
ce2c0543
b7b783d7
+3
-1
+3
-1
src/applications/differential/editor/DifferentialCommentEditor.php
+3
-1
src/applications/differential/editor/DifferentialCommentEditor.php
···
645
645
$added_reviewers = $this->getAddedReviewers();
646
646
$removed_reviewers = $this->getRemovedReviewers();
647
647
$reviewer_phids = $revision->getReviewers();
648
+
$allow_self_accept = PhabricatorEnv::getEnvConfig(
649
+
'differential.allow-self-accept', false);
648
650
649
651
$reviewer_phids_map = array_fill_keys($reviewer_phids, true);
650
652
foreach ($added_reviewers as $k => $user_phid) {
651
-
if ($user_phid == $revision->getAuthorPHID()) {
653
+
if (!$allow_self_accept && $user_phid == $revision->getAuthorPHID()) {
652
654
unset($added_reviewers[$k]);
653
655
}
654
656
if (isset($reviewer_phids_map[$user_phid])) {