@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conpherence - make sure "Join" action in public room works even with no message text
Summary: Fixes T8328. Somewhere along the line we stopped posting to the server with no text. Make sure if the action is join_room that we ping the server even if no text is specified.
Test Plan: tried to send an empty message and failed; nothing happened when I clicked. tried to join a room with an empty message and it worked
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8328
Differential Revision: https://secure.phabricator.com/D13041
+26
-15
+14
-14
resources/celerity/map.php
+14
-14
resources/celerity/map.php
···
8
8
return array(
9
9
'names' => array(
10
10
'core.pkg.css' => '97a49e3e',
11
-
'core.pkg.js' => '328799d0',
11
+
'core.pkg.js' => '0e261ea7',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '30602b8c',
14
14
'differential.pkg.js' => '8c98ce21',
···
334
334
'rsrc/js/application/calendar/behavior-day-view.js' => '5c46cff2',
335
335
'rsrc/js/application/calendar/behavior-event-all-day.js' => '38dcf3c8',
336
336
'rsrc/js/application/config/behavior-reorder-fields.js' => 'b6993408',
337
-
'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '10246726',
337
+
'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '01774ab2',
338
338
'rsrc/js/application/conpherence/behavior-drag-and-drop-photo.js' => 'cf86d16a',
339
339
'rsrc/js/application/conpherence/behavior-durable-column.js' => '16c695bf',
340
340
'rsrc/js/application/conpherence/behavior-menu.js' => 'c0348cac',
···
504
504
'conpherence-menu-css' => 'f389e048',
505
505
'conpherence-message-pane-css' => '5bb4b76d',
506
506
'conpherence-notification-css' => '919974b6',
507
-
'conpherence-thread-manager' => '10246726',
507
+
'conpherence-thread-manager' => '01774ab2',
508
508
'conpherence-transaction-css' => '42a457f6',
509
509
'conpherence-update-css' => '1099a660',
510
510
'conpherence-widget-pane-css' => '2af42ebe',
···
827
827
'unhandled-exception-css' => '37d4f9a2',
828
828
),
829
829
'requires' => array(
830
+
'01774ab2' => array(
831
+
'javelin-dom',
832
+
'javelin-util',
833
+
'javelin-stratcom',
834
+
'javelin-install',
835
+
'javelin-aphlict',
836
+
'javelin-workflow',
837
+
'javelin-router',
838
+
'javelin-behavior-device',
839
+
'javelin-vector',
840
+
),
830
841
'029a133d' => array(
831
842
'aphront-dialog-view-css',
832
843
),
···
889
900
'0f764c35' => array(
890
901
'javelin-install',
891
902
'javelin-util',
892
-
),
893
-
10246726 => array(
894
-
'javelin-dom',
895
-
'javelin-util',
896
-
'javelin-stratcom',
897
-
'javelin-install',
898
-
'javelin-aphlict',
899
-
'javelin-workflow',
900
-
'javelin-router',
901
-
'javelin-behavior-device',
902
-
'javelin-vector',
903
903
),
904
904
'13c739ea' => array(
905
905
'javelin-behavior',
+12
-1
webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js
+12
-1
webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js
···
447
447
},
448
448
449
449
sendMessage: function(form, params) {
450
+
var inputs = JX.DOM.scry(form, 'input');
451
+
var block_empty = true;
452
+
for (var i = 0; i < inputs.length; i++) {
453
+
if (inputs[i].type != 'hidden') {
454
+
continue;
455
+
}
456
+
if (inputs[i].name == 'action' && inputs[i].value == 'join_room') {
457
+
block_empty = false;
458
+
continue;
459
+
}
460
+
}
450
461
// don't bother sending up text if there is nothing to submit
451
462
var textarea = JX.DOM.find(form, 'textarea');
452
-
if (!textarea.value.length) {
463
+
if (block_empty && !textarea.value.length) {
453
464
return;
454
465
}
455
466
params = this._getParams(params);