recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't show error operations after a successful land operation

Summary:
Ref T182. When viewing a revision, if there are several error operations and then a success operation, we currently show the last error. This is misleading.

Instead, don't show anything if there's a success (this may require tuning eventually if you can land multiple times onto different branches or whatever, but should be reasonable for now).

Also make the table a little nicer, particularly for merge failure output.

Test Plan: {F910385}

Reviewers: chad, Mnkras

Reviewed By: Mnkras

Maniphest Tasks: T182

Differential Revision: https://secure.phabricator.com/D14348

authored by

epriestley and committed by
epriestley cea633f6 6e7ceb99

+11 -10
+3 -3
resources/celerity/map.php
··· 7 7 */ 8 8 return array( 9 9 'names' => array( 10 - 'core.pkg.css' => 'c65b251d', 10 + 'core.pkg.css' => 'd80f5c3e', 11 11 'core.pkg.js' => '47dc9ebb', 12 12 'darkconsole.pkg.js' => 'e7393ebb', 13 13 'differential.pkg.css' => '2de124c9', ··· 25 25 'rsrc/css/aphront/notification.css' => '9c279160', 26 26 'rsrc/css/aphront/panel-view.css' => '8427b78d', 27 27 'rsrc/css/aphront/phabricator-nav-view.css' => 'a24cb589', 28 - 'rsrc/css/aphront/table-view.css' => '63985f5b', 28 + 'rsrc/css/aphront/table-view.css' => '61543e7a', 29 29 'rsrc/css/aphront/tokenizer.css' => '04875312', 30 30 'rsrc/css/aphront/tooltip.css' => '7672b60f', 31 31 'rsrc/css/aphront/typeahead-browse.css' => 'd8581d2c', ··· 493 493 'aphront-list-filter-view-css' => '5d6f0526', 494 494 'aphront-multi-column-view-css' => 'fd18389d', 495 495 'aphront-panel-view-css' => '8427b78d', 496 - 'aphront-table-view-css' => '63985f5b', 496 + 'aphront-table-view-css' => '61543e7a', 497 497 'aphront-tokenizer-control-css' => '04875312', 498 498 'aphront-tooltip-css' => '7672b60f', 499 499 'aphront-typeahead-control-css' => '0e403212',
+6 -6
src/applications/differential/controller/DifferentialRevisionViewController.php
··· 1051 1051 array( 1052 1052 DrydockLandRepositoryOperation::OPCONST, 1053 1053 )) 1054 - ->withOperationStates( 1055 - array( 1056 - DrydockRepositoryOperation::STATE_WAIT, 1057 - DrydockRepositoryOperation::STATE_WORK, 1058 - DrydockRepositoryOperation::STATE_FAIL, 1059 - )) 1060 1054 ->execute(); 1061 1055 if (!$operations) { 1062 1056 return null; ··· 1071 1065 if ($operation->getOperationState() != $state_fail) { 1072 1066 break; 1073 1067 } 1068 + } 1069 + 1070 + // If we found a completed operation, don't render anything. We don't want 1071 + // to show an older error after the thing worked properly. 1072 + if ($operation->isDone()) { 1073 + return null; 1074 1074 } 1075 1075 1076 1076 $box_view = id(new PHUIObjectBoxView())
+1 -1
src/applications/drydock/view/DrydockRepositoryOperationStatusView.php
··· 115 115 ->setColumnClasses( 116 116 array( 117 117 'header', 118 - 'wide', 118 + 'wide prewrap', 119 119 )); 120 120 121 121 return $table;
+1
webroot/rsrc/css/aphront/table-view.css
··· 61 61 text-align: right; 62 62 color: {$bluetext}; 63 63 font-weight: bold; 64 + vertical-align: top; 64 65 } 65 66 66 67 .aphront-table-view td {