recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Ask users to choose a pronoun instead of sex in the Account settings panel

Summary: Fixes T4845, Use "choose a pronoun" prompt for (grammatical) gender selection instead of "Sex"

Test Plan: Open Account settings panel, expand Pronoun dropdown, verify that options are "<username> updated their/her/his profile". Switch to different language, verify that pronouns propogate

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T4845

Differential Revision: https://secure.phabricator.com/D8920

authored by

lkassianik and committed by
epriestley cf3f8cd8 23e654ec

+10 -4
+10 -4
src/applications/settings/panel/PhabricatorSettingsPanelAccount.php
··· 17 17 18 18 public function processRequest(AphrontRequest $request) { 19 19 $user = $request->getUser(); 20 + $username = $user->getUsername(); 20 21 21 22 $pref_time = PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT; 22 23 $preferences = $user->loadPreferences(); ··· 54 55 $timezone_ids = DateTimeZone::listIdentifiers(); 55 56 $timezone_id_map = array_fuse($timezone_ids); 56 57 58 + $label_unknown = pht('%s updated their profile', $username); 59 + $label_her = pht('%s updated her profile', $username); 60 + $label_his = pht('%s updated his profile', $username); 61 + 57 62 $sexes = array( 58 - PhutilPerson::SEX_UNKNOWN => pht('Unspecified'), 59 - PhutilPerson::SEX_MALE => pht('Male'), 60 - PhutilPerson::SEX_FEMALE => pht('Female'), 63 + PhutilPerson::SEX_UNKNOWN => $label_unknown, 64 + PhutilPerson::SEX_MALE => $label_his, 65 + PhutilPerson::SEX_FEMALE => $label_her, 61 66 ); 62 67 63 68 $translations = array(); ··· 85 90 ->setName('timezone') 86 91 ->setOptions($timezone_id_map) 87 92 ->setValue($user->getTimezoneIdentifier())) 93 + ->appendRemarkupInstructions(pht("**Choose the pronoun you prefer:**")) 88 94 ->appendChild( 89 95 id(new AphrontFormSelectControl()) 90 96 ->setOptions($sexes) 91 - ->setLabel(pht('Sex')) 97 + ->setLabel(pht('Pronoun')) 92 98 ->setName('sex') 93 99 ->setValue($user->getSex())) 94 100 ->appendChild(