recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Improve chat column behavior for newline in empty text box

Summary: Ref T7538. I got this half correct but not fully correct: when you press enter in an empty text box, do nothing (instead of: sending an empty message, or writing a literal newline).

Test Plan: Hit enter in empty chat column box.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7538

Differential Revision: https://secure.phabricator.com/D12089

epriestley cf54194e cc7a9660

+16 -12
+12 -12
resources/celerity/map.php
··· 353 353 'rsrc/js/application/auth/behavior-persona-login.js' => '9414ff18', 354 354 'rsrc/js/application/config/behavior-reorder-fields.js' => '14a827de', 355 355 'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => 'cff1902b', 356 - 'rsrc/js/application/conpherence/behavior-durable-column.js' => '332ac18d', 356 + 'rsrc/js/application/conpherence/behavior-durable-column.js' => 'e975bd12', 357 357 'rsrc/js/application/conpherence/behavior-menu.js' => 'c4151295', 358 358 'rsrc/js/application/conpherence/behavior-pontificate.js' => '21ba5861', 359 359 'rsrc/js/application/conpherence/behavior-quicksand-blacklist.js' => '7927a7d3', ··· 583 583 'javelin-behavior-diffusion-locate-file' => '6d3e1947', 584 584 'javelin-behavior-diffusion-pull-lastmodified' => '2b228192', 585 585 'javelin-behavior-doorkeeper-tag' => 'e5822781', 586 - 'javelin-behavior-durable-column' => '332ac18d', 586 + 'javelin-behavior-durable-column' => 'e975bd12', 587 587 'javelin-behavior-error-log' => '6882e80a', 588 588 'javelin-behavior-fancy-datepicker' => 'c51ae228', 589 589 'javelin-behavior-global-drag-and-drop' => 'bbdf75ca', ··· 1053 1053 ), 1054 1054 '331b1611' => array( 1055 1055 'javelin-install', 1056 - ), 1057 - '332ac18d' => array( 1058 - 'javelin-behavior', 1059 - 'javelin-dom', 1060 - 'javelin-stratcom', 1061 - 'javelin-behavior-device', 1062 - 'javelin-scrollbar', 1063 - 'javelin-quicksand', 1064 - 'phabricator-keyboard-shortcut', 1065 - 'conpherence-thread-manager', 1066 1056 ), 1067 1057 '3ab51e2c' => array( 1068 1058 'javelin-behavior', ··· 1902 1892 'javelin-workflow', 1903 1893 'javelin-dom', 1904 1894 'phabricator-draggable-list', 1895 + ), 1896 + 'e975bd12' => array( 1897 + 'javelin-behavior', 1898 + 'javelin-dom', 1899 + 'javelin-stratcom', 1900 + 'javelin-behavior-device', 1901 + 'javelin-scrollbar', 1902 + 'javelin-quicksand', 1903 + 'phabricator-keyboard-shortcut', 1904 + 'conpherence-thread-manager', 1905 1905 ), 1906 1906 'ea681761' => array( 1907 1907 'javelin-behavior',
+4
webroot/rsrc/js/application/conpherence/behavior-durable-column.js
··· 296 296 return; 297 297 } 298 298 299 + // From here on, interpret this as a "send" action, not a literal 300 + // newline. 301 + e.kill(); 302 + 299 303 var textarea = _getColumnTextareaNode(); 300 304 if (!textarea.value.length) { 301 305 // If there's no text, don't try to submit the form.