@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Ignore PHAR extensions in Version Check and a Celerity test
Summary:
in /config/ page, don't try to figure out versions for PHAR-packaged extensions for now.
We'll work something out eventually.
Depends on D26379. Refs T16300
Test Plan: load PHAR extension, look at config page, no errors in log.
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T16300
Differential Revision: https://we.phorge.it/D26507
+29
+11
src/__tests__/PhabricatorCelerityTestCase.php
+11
src/__tests__/PhabricatorCelerityTestCase.php
···
9
9
public function testCelerityMaps() {
10
10
$resources_map = CelerityPhysicalResources::getAll();
11
11
12
+
// The ../ hack works for Phorge, and that's good enough for now.
13
+
$phorge_path = Filesystem::resolvePath(
14
+
'../',
15
+
phutil_get_library_root('phorge'));
16
+
$phorge_path_len = strlen($phorge_path);
17
+
12
18
foreach ($resources_map as $resources) {
19
+
$map_path = $resources->getPathToMap();
20
+
if (strncmp($phorge_path, $map_path, $phorge_path_len)) {
21
+
// This resource is from another repository
22
+
continue;
23
+
}
13
24
$old_map = new CelerityResourceMap($resources);
14
25
15
26
$new_map = id(new CelerityResourceMapGenerator($resources))
+18
src/applications/config/controller/PhabricatorConfigConsoleController.php
+18
src/applications/config/controller/PhabricatorConfigConsoleController.php
···
153
153
foreach ($specs as $lib) {
154
154
$root = dirname(phutil_get_library_root($lib));
155
155
156
+
if (Filesystem::isPharPath($root)) {
157
+
continue;
158
+
}
159
+
156
160
$log_command = csprintf(
157
161
'git log --format=%s -n 1 --',
158
162
'%H %ct');
···
187
191
$upstream_futures = array();
188
192
$lib_upstreams = array();
189
193
foreach ($specs as $lib) {
194
+
if (!array_key_exists($lib, $remote_futures)) {
195
+
continue;
196
+
}
190
197
$remote_future = $remote_futures[$lib];
191
198
192
199
try {
···
291
298
}
292
299
293
300
$results[$lib] = $result;
301
+
}
302
+
303
+
foreach ($specs as $lib) {
304
+
if (!array_key_exists($lib, $results)) {
305
+
$results[$lib] = array(
306
+
'hash' => null,
307
+
'epoch' => null,
308
+
'upstream' => null,
309
+
'branchpoint' => null,
310
+
);
311
+
}
294
312
}
295
313
296
314
return $results;