+1 -1

resources/sql/patches/098.heraldruletypemigration.php

reviewed

··· 41 41 $rule->getRuleType(), 42 42 $rule->getID()); 43 43 44 44 - echo "Setting rule '" . $rule->getName() . "' to personal. "; 44 44 + echo "Setting rule '".$rule->getName()."' to personal. "; 45 45 } 46 46 } 47 47 }

+1 -1

scripts/aphront/aphrontpath.php

reviewed

··· 22 22 list($controller) = $application->buildControllerForPath($path.'/'); 23 23 } 24 24 if ($controller) { 25 25 - echo get_class($controller) . "\n"; 25 25 + echo get_class($controller)."\n"; 26 26 }

+1 -1

scripts/symbols/generate_ctags_symbols.php

reviewed

··· 110 110 if ($file[0] == '.' || $file[0] == '..') { 111 111 array_shift($file); 112 112 } 113 113 - $file = '/' . implode('/', $file); 113 113 + $file = '/'.implode('/', $file); 114 114 115 115 $parts = array( 116 116 $context,

+13 -13

src/aphront/AphrontRequest.php

reviewed

··· 231 231 if (PhabricatorEnv::getEnvConfig('phabricator.developer-mode')) { 232 232 // TODO: Clean this up, see T1921. 233 233 $more_info[] = 234 234 - "To avoid this error, use phabricator_form() to construct forms. " . 235 235 - "If you are already using phabricator_form(), make sure the form " . 236 236 - "'action' uses a relative URI (i.e., begins with a '/'). Forms " . 237 237 - "using absolute URIs do not include CSRF tokens, to prevent " . 238 238 - "leaking tokens to external sites.\n\n" . 239 239 - "If this page performs writes which do not require CSRF " . 240 240 - "protection (usually, filling caches or logging), you can use " . 241 241 - "AphrontWriteGuard::beginScopedUnguardedWrites() to temporarily " . 242 242 - "bypass CSRF protection while writing. You should use this only " . 243 243 - "for writes which can not be protected with normal CSRF " . 244 244 - "mechanisms.\n\n" . 245 245 - "Some UI elements (like PhabricatorActionListView) also have " . 246 246 - "methods which will allow you to render links as forms (like " . 234 234 + "To avoid this error, use phabricator_form() to construct forms. ". 235 235 + "If you are already using phabricator_form(), make sure the form ". 236 236 + "'action' uses a relative URI (i.e., begins with a '/'). Forms ". 237 237 + "using absolute URIs do not include CSRF tokens, to prevent ". 238 238 + "leaking tokens to external sites.\n\n". 239 239 + "If this page performs writes which do not require CSRF ". 240 240 + "protection (usually, filling caches or logging), you can use ". 241 241 + "AphrontWriteGuard::beginScopedUnguardedWrites() to temporarily ". 242 242 + "bypass CSRF protection while writing. You should use this only ". 243 243 + "for writes which can not be protected with normal CSRF ". 244 244 + "mechanisms.\n\n". 245 245 + "Some UI elements (like PhabricatorActionListView) also have ". 246 246 + "methods which will allow you to render links as forms (like ". 247 247 "setRenderAsForm(true))."; 248 248 } 249 249

+2 -2

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

reviewed

··· 261 261 ->setAuditorPHID($auditor_phid) 262 262 ->setAuditStatus($audit_requested) 263 263 ->setAuditReasons( 264 264 - array('Added by ' . $actor->getUsername())) 264 264 + array('Added by '.$actor->getUsername())) 265 265 ->save(); 266 266 } 267 267 } ··· 274 274 ->setAuditorPHID($cc_phid) 275 275 ->setAuditStatus($audit_cc) 276 276 ->setAuditReasons( 277 277 - array('Added by ' . $actor->getUsername())) 277 277 + array('Added by '.$actor->getUsername())) 278 278 ->save(); 279 279 } 280 280 }

+1 -1

src/applications/auth/provider/PhabricatorAuthProviderOAuth.php

reviewed

··· 81 81 public function getConfigurationHelp() { 82 82 $help = $this->getProviderConfigurationHelp(); 83 83 84 84 - return $help . "\n\n" . 84 84 + return $help."\n\n". 85 85 pht('Use the **OAuth App Notes** field to record details about which '. 86 86 'account the external application is registered under.'); 87 87 }

+4 -4

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

reviewed

··· 152 152 array( 153 153 'href' => $first_uri, 154 154 ), 155 155 - "\xC2\xAB ". pht('Newest')); 155 155 + "\xC2\xAB ".pht('Newest')); 156 156 } 157 157 158 158 $prev_uri = $pager->getPrevPageURI(); ··· 162 162 array( 163 163 'href' => $prev_uri, 164 164 ), 165 165 - "\xE2\x80\xB9 " . pht('Newer')); 165 165 + "\xE2\x80\xB9 ".pht('Newer')); 166 166 } 167 167 168 168 $next_uri = $pager->getNextPageURI(); ··· 172 172 array( 173 173 'href' => $next_uri, 174 174 ), 175 175 - pht('Older') . " \xE2\x80\xBA"); 175 175 + pht('Older')." \xE2\x80\xBA"); 176 176 } 177 177 178 178 $pager_top = phutil_tag( ··· 224 224 array( 225 225 'href' => '#latest' 226 226 ), 227 227 - pht('Jump to Bottom') . " \xE2\x96\xBE"); 227 227 + pht('Jump to Bottom')." \xE2\x96\xBE"); 228 228 229 229 $jump = phutil_tag( 230 230 'div',

+2 -2

src/applications/conduit/call/ConduitCall.php

reviewed

··· 27 27 $this->handler->defineParamTypes()); 28 28 if ($invalid_params) { 29 29 throw new ConduitException( 30 30 - "Method '{$method}' doesn't define these parameters: '" . 31 31 - implode("', '", array_keys($invalid_params)) . "'."); 30 30 + "Method '{$method}' doesn't define these parameters: '". 31 31 + implode("', '", array_keys($invalid_params))."'."); 32 32 } 33 33 34 34 if ($this->servers) {

+1 -1

src/applications/config/controller/PhabricatorConfigIgnoreController.php

reviewed

··· 34 34 'This issue will no longer be suppressed, and will return to its '. 35 35 'rightful place as a global setup warning.'); 36 36 } else { 37 37 - throw new Exception('Unrecognized verb: ' . $this->verb); 37 37 + throw new Exception('Unrecognized verb: '.$this->verb); 38 38 } 39 39 40 40 $dialog = id(new AphrontDialogView())

+2 -2

src/applications/conpherence/controller/ConpherenceWidgetController.php

reviewed

··· 274 274 phabricator_format_local_time( 275 275 $status->getDateFrom(), 276 276 $user, 277 277 - $time_str) . 278 278 - ' - ' . 277 277 + $time_str). 278 278 + ' - '. 279 279 phabricator_format_local_time( 280 280 $status->getDateTo(), 281 281 $user,

+2 -2

src/applications/conpherence/view/ConpherenceLayoutView.php

reviewed

··· 59 59 $selected_id = null; 60 60 $selected_thread_id = null; 61 61 if ($this->thread) { 62 62 - $selected_id = $this->thread->getPHID() . '-nav-item'; 62 62 + $selected_id = $this->thread->getPHID().'-nav-item'; 63 63 $selected_thread_id = $this->thread->getID(); 64 64 } 65 65 $this->initBehavior('conpherence-menu', ··· 77 77 $this->initBehavior( 78 78 'conpherence-widget-pane', 79 79 array( 80 80 - 'widgetBaseUpdateURI' => $this->baseURI . 'update/', 80 80 + 'widgetBaseUpdateURI' => $this->baseURI.'update/', 81 81 'widgetRegistry' => array( 82 82 'conpherence-message-pane' => array( 83 83 'name' => pht('Thread'),

+1 -1

src/applications/dashboard/controller/PhabricatorDashboardViewController.php

reviewed

··· 70 70 'yet. Use %s to add panels.', 71 71 phutil_tag( 72 72 'a', 73 73 - array('href'=>$manage_uri), 73 73 + array('href' => $manage_uri), 74 74 pht('Manage Dashboard')))); 75 75 } 76 76

+2 -2

src/applications/differential/DifferentialGetWorkingCopy.php

reviewed

··· 17 17 $origin_path = $repo->getLocalPath(); 18 18 19 19 $path = rtrim($origin_path, '/'); 20 20 - $path = $path . '__workspace'; 20 20 + $path = $path.'__workspace'; 21 21 22 22 if (!Filesystem::pathExists($path)) { 23 23 $repo->execxLocalCommand( ··· 53 53 $origin_path = $repo->getLocalPath(); 54 54 55 55 $path = rtrim($origin_path, '/'); 56 56 - $path = $path . '__workspace'; 56 56 + $path = $path.'__workspace'; 57 57 58 58 if (!Filesystem::pathExists($path)) { 59 59 $repo->execxLocalCommand(

+1 -1

src/applications/differential/editor/DifferentialTransactionEditor.php

reviewed

··· 1322 1322 $result[] = "{$file}:{$range} {$inline_content}"; 1323 1323 } else { 1324 1324 $result[] = '================'; 1325 1325 - $result[] = 'Comment at: ' . $file . ':' . $range; 1325 1325 + $result[] = 'Comment at: '.$file.':'.$range; 1326 1326 $result[] = $hunk_parser->makeContextDiff( 1327 1327 $changeset->getHunks(), 1328 1328 $comment->getIsNewFile(),

+3 -3

src/applications/differential/landing/DifferentialLandingToHostedGit.php

reviewed

··· 53 53 54 54 $missing_binary = 55 55 "\nindex " 56 56 - . "0000000000000000000000000000000000000000.." 57 57 - . "0000000000000000000000000000000000000000\n"; 56 56 + ."0000000000000000000000000000000000000000.." 57 57 + ."0000000000000000000000000000000000000000\n"; 58 58 if (strpos($raw_diff, $missing_binary) !== false) { 59 59 throw new Exception('Patch is missing content for a binary file'); 60 60 } ··· 85 85 $author_date = $revision->getDateCreated(); 86 86 87 87 $workspace->execxLocal( 88 88 - '-c user.name=%s -c user.email=%s ' . 88 88 + '-c user.name=%s -c user.email=%s '. 89 89 'commit --date=%s --author=%s '. 90 90 '--message=%s', 91 91 // -c will set the 'committer'

+2 -2

src/applications/differential/mail/DifferentialReplyHandler.php

reviewed

··· 105 105 // unrecognized commands will be parsed as part of the comment. 106 106 $command = DifferentialAction::ACTION_COMMENT; 107 107 $supported_commands = $this->getSupportedCommands(); 108 108 - $regex = "/\A\n*!(" . implode('|', $supported_commands) . ")\n*/"; 108 108 + $regex = "/\A\n*!(".implode('|', $supported_commands).")\n*/"; 109 109 $matches = array(); 110 110 if (preg_match($regex, $body, $matches)) { 111 111 $command = $matches[1]; 112 112 - $body = trim(str_replace('!' . $command, '', $body)); 112 112 + $body = trim(str_replace('!'.$command, '', $body)); 113 113 } 114 114 115 115 $actor = $this->getActor();

+4 -4

src/applications/differential/parser/DifferentialHunkParser.php

reviewed

··· 638 638 if ($hunk_offset['-'] !== null || $hunk_offset['+'] !== null) { 639 639 $header = '@@'; 640 640 if ($hunk_offset['-'] !== null) { 641 641 - $header .= ' -' . ($hunk->getOldOffset() + $hunk_offset['-']) . 642 642 - ',' . ($hunk_last['-'] - $hunk_offset['-'] + 1); 641 641 + $header .= ' -'.($hunk->getOldOffset() + $hunk_offset['-']). 642 642 + ','.($hunk_last['-'] - $hunk_offset['-'] + 1); 643 643 } 644 644 if ($hunk_offset['+'] !== null) { 645 645 - $header .= ' +' . ($hunk->getNewOffset() + $hunk_offset['+']) . 646 646 - ',' . ($hunk_last['+'] - $hunk_offset['+'] + 1); 645 645 + $header .= ' +'.($hunk->getNewOffset() + $hunk_offset['+']). 646 646 + ','.($hunk_last['+'] - $hunk_offset['+'] + 1); 647 647 } 648 648 $header .= ' @@'; 649 649 $context[] = $header;

-1

src/applications/differential/parser/__tests__/data/missing_context.diff

reviewed

··· 8 8 fig 9 9 -grape 10 10 honeydew 11 11 -

-1

src/applications/differential/parser/__tests__/data/missing_context_2.diff

reviewed

··· 9 9 +guava 10 10 +gooseberry 11 11 honeydew 12 12 -

-1

src/applications/differential/parser/__tests__/data/missing_context_3.diff

reviewed

··· 15 15 banana 16 16 grape 17 17 -honeydew 18 18 -

+1 -1

src/applications/differential/view/DifferentialInlineCommentView.php

reviewed

··· 75 75 76 76 $sigil = 'differential-inline-comment'; 77 77 if ($this->preview) { 78 78 - $sigil = $sigil . ' differential-inline-comment-preview'; 78 78 + $sigil = $sigil.' differential-inline-comment-preview'; 79 79 } 80 80 81 81 $content = $inline->getContent();

+1 -1

src/applications/diffusion/protocol/__tests__/DiffusionSubversionWireProtocolTestCase.php

reviewed

··· 78 78 'value' => 'duck', 79 79 ), 80 80 array( 81 81 - 'type'=> 'string', 81 81 + 'type' => 'string', 82 82 'value' => 'quack', 83 83 ), 84 84 ),

+2 -2

src/applications/diffusion/request/DiffusionRequest.php

reviewed

··· 691 691 $host = php_uname('n'); 692 692 $callsign = $this->getRepository()->getCallsign(); 693 693 throw new DiffusionSetupException( 694 694 - "The clone of this repository ('{$callsign}') on the local machine " . 695 695 - "('{$host}') could not be read. Ensure that the repository is in a " . 694 694 + "The clone of this repository ('{$callsign}') on the local machine ". 695 695 + "('{$host}') could not be read. Ensure that the repository is in a ". 696 696 "location where the web server has read permissions."); 697 697 } 698 698

+1 -1

src/applications/diffusion/view/DiffusionView.php

reviewed

··· 120 120 $callsign = $repository->getCallsign(); 121 121 122 122 if (strlen($summary)) { 123 123 - $commit_name .= ': ' . $summary; 123 123 + $commit_name .= ': '.$summary; 124 124 } 125 125 126 126 return phutil_tag(

+1 -1

src/applications/feed/conduit/ConduitAPI_feed_query_Method.php

reviewed

··· 44 44 45 45 return array( 46 46 'ERR-UNKNOWN-TYPE' => 47 47 - 'Unsupported view type, possibles are: ' . $view_types 47 47 + 'Unsupported view type, possibles are: '.$view_types 48 48 ); 49 49 } 50 50

+1 -1

src/applications/herald/adapter/HeraldAdapter.php

reviewed

··· 483 483 // We add the 'S' flag because we use the regexp multiple times. 484 484 // It shouldn't cause any troubles if the flag is already there 485 485 // - /.*/S is evaluated same as /.*/SS. 486 486 - $result = @preg_match($condition_value . 'S', $value); 486 486 + $result = @preg_match($condition_value.'S', $value); 487 487 if ($result === false) { 488 488 throw new HeraldInvalidConditionException( 489 489 'Regular expression is not valid!');

+1 -1

src/applications/herald/controller/HeraldRuleController.php

reviewed

··· 643 643 foreach ($all_rules as $current_rule) { 644 644 if ($current_rule->getIsDisabled()) { 645 645 $current_rule->makeEphemeral(); 646 646 - $current_rule->setName($rule->getName(). ' '.pht('(Disabled)')); 646 646 + $current_rule->setName($rule->getName().' '.pht('(Disabled)')); 647 647 } 648 648 } 649 649

+2 -2

src/applications/meta/controller/PhabricatorApplicationUninstallController.php

reviewed

··· 54 54 if ($selected->canUninstall()) { 55 55 $dialog->setTitle('Confirmation') 56 56 ->appendChild( 57 57 - 'Install '. $selected->getName(). ' application?') 57 57 + 'Install '.$selected->getName().' application?') 58 58 ->addSubmitButton('Install'); 59 59 60 60 } else { ··· 65 65 if ($selected->canUninstall()) { 66 66 $dialog->setTitle('Confirmation') 67 67 ->appendChild( 68 68 - 'Really Uninstall '. $selected->getName(). ' application?') 68 68 + 'Really Uninstall '.$selected->getName().' application?') 69 69 ->addSubmitButton('Uninstall'); 70 70 } else { 71 71 $dialog->setTitle('Information')

+2 -2

src/applications/metamta/parser/__tests__/PhabricatorMetaMTAEmailBodyParserTestCase.php

reviewed

··· 49 49 $bodies = $this->getEmailBodies(); 50 50 $with_commands = array(); 51 51 foreach ($bodies as $body) { 52 52 - $with_commands[] = "!whatevs dude\n" . $body; 52 52 + $with_commands[] = "!whatevs dude\n".$body; 53 53 } 54 54 return $with_commands; 55 55 } ··· 58 58 $bodies = $this->getEmailBodies(); 59 59 $with_commands = array(); 60 60 foreach ($bodies as $body) { 61 61 - $with_commands[] = "!whatevs\n" . $body; 61 61 + $with_commands[] = "!whatevs\n".$body; 62 62 } 63 63 return $with_commands; 64 64 }

+1 -1

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php

reviewed

··· 239 239 $single_handle_prefix = PhabricatorEnv::getEnvConfig( 240 240 'metamta.single-reply-handler-prefix'); 241 241 return ($single_handle_prefix) 242 242 - ? $single_handle_prefix . '+' . $address 242 242 + ? $single_handle_prefix.'+'.$address 243 243 : $address; 244 244 } 245 245

+4 -4

src/applications/owners/conduit/ConduitAPI_owners_query_Method.php

reviewed

··· 7 7 extends ConduitAPI_owners_Method { 8 8 9 9 public function getMethodDescription() { 10 10 - return 'Query for packages by one of the following: repository/path, ' . 11 11 - 'packages with a given user or project owner, or packages affiliated ' . 12 12 - 'with a user (owned by either the user or a project they are a member ' . 10 10 + return 'Query for packages by one of the following: repository/path, '. 11 11 + 'packages with a given user or project owner, or packages affiliated '. 12 12 + 'with a user (owned by either the user or a project they are a member '. 13 13 'of.) You should only provide at most one search query.'; 14 14 } 15 15 ··· 31 31 public function defineErrorTypes() { 32 32 return array( 33 33 'ERR-INVALID-USAGE' => 34 34 - 'Provide one of a single owner phid (user/project), a single ' . 34 34 + 'Provide one of a single owner phid (user/project), a single '. 35 35 'affiliated user phid (user), or a repository/path.', 36 36 'ERR-INVALID-PARAMETER' => 'parameter should be a phid', 37 37 'ERR_REP_NOT_FOUND' => 'The repository callsign is not recognized',

+1 -1

src/applications/owners/mail/PackageMail.php

reviewed

··· 44 44 $handles = $this->getHandles(); 45 45 $section = array(); 46 46 $section[] = ' In repository '.$handles[$repository_phid]->getName(). 47 47 - ' - '. PhabricatorEnv::getProductionURI($handles[$repository_phid] 47 47 + ' - '.PhabricatorEnv::getProductionURI($handles[$repository_phid] 48 48 ->getURI()); 49 49 foreach ($paths as $path => $excluded) { 50 50 $section[] = ' '.($excluded ? 'Excluded' : 'Included').' '.$path;

+2 -2

src/applications/owners/mail/PackageModifyMail.php

reviewed

··· 81 81 82 82 $section = array(); 83 83 $section[] = 'PRIMARY OWNER CHANGE'; 84 84 - $section[] = ' Old owner: ' . 84 84 + $section[] = ' Old owner: '. 85 85 $handles[$old_primary_owner_phid]->getName(); 86 86 - $section[] = ' New owner: ' . 86 86 + $section[] = ' New owner: '. 87 87 $handles[$primary_owner_phid]->getName(); 88 88 89 89 return implode("\n", $section);

+2 -2

src/applications/owners/query/PhabricatorOwnerPathQuery.php

reviewed

··· 20 20 21 21 $result = array(); 22 22 foreach ($paths as $path) { 23 23 - $basic_path = '/' . $path->getPath(); 23 23 + $basic_path = '/'.$path->getPath(); 24 24 if ($path->getFileType() == DifferentialChangeType::FILE_DIRECTORY) { 25 25 - $basic_path = rtrim($basic_path, '/') . '/'; 25 25 + $basic_path = rtrim($basic_path, '/').'/'; 26 26 } 27 27 $result[] = $basic_path; 28 28 }

+3 -3

src/applications/pholio/query/PholioMockSearchEngine.php

reviewed

··· 41 41 ->execute(); 42 42 43 43 $statuses = array( 44 44 - ''=>pht('Any Status'), 45 45 - 'closed'=>pht('Closed'), 46 46 - 'open'=>pht('Open')); 44 44 + '' => pht('Any Status'), 45 45 + 'closed' => pht('Closed'), 46 46 + 'open' => pht('Open')); 47 47 48 48 $status = $saved_query->getParameter('statuses', array()); 49 49 $status = head($status);

+1 -1

src/applications/phrequent/controller/PhrequentTrackController.php

reviewed

··· 23 23 24 24 if (!$this->isStartingTracking() && 25 25 !$this->isStoppingTracking()) { 26 26 - throw new Exception('Unrecognized verb: ' . $this->verb); 26 26 + throw new Exception('Unrecognized verb: '.$this->verb); 27 27 } 28 28 29 29 switch ($this->verb) {

+1 -1

src/applications/project/controller/PhabricatorProjectEditIconController.php

reviewed

··· 66 66 67 67 if ($icon == $project->getIcon()) { 68 68 $class_extra = ' selected'; 69 69 - $tip = $label . pht(' - selected'); 69 69 + $tip = $label.pht(' - selected'); 70 70 } else { 71 71 $class_extra = null; 72 72 $tip = $label;

+1 -1

src/applications/releeph/controller/product/ReleephProductEditController.php

reviewed

··· 162 162 ->setValue($pick_failure_instructions) 163 163 ->setName('pickFailureInstructions') 164 164 ->setCaption( 165 165 - pht('Instructions for pick failures, which will be used ' . 165 165 + pht('Instructions for pick failures, which will be used '. 166 166 'in emails generated by failed picks'))) 167 167 ->appendChild( 168 168 id(new AphrontFormTextAreaControl())

+1 -1

src/applications/releeph/controller/request/ReleephRequestEditController.php

reviewed

··· 196 196 $age_string = ''; 197 197 if ($is_edit) { 198 198 $age_string = phabricator_format_relative_time( 199 199 - time() - $pull->getDateCreated()) . ' ago'; 199 199 + time() - $pull->getDateCreated()).' ago'; 200 200 } 201 201 202 202 // Warn the user if we've been redirected here because we tried to

+2 -2

src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php

reviewed

··· 113 113 ->setOptions( 114 114 array( 115 115 'glyph' => 116 116 - pht("In page titles, show Tool names as unicode glyphs: " . 116 116 + pht("In page titles, show Tool names as unicode glyphs: ". 117 117 "\xE2\x9A\x99"), 118 118 'text' => 119 119 - pht('In page titles, show Tool names as plain text: ' . 119 119 + pht('In page titles, show Tool names as plain text: '. 120 120 '[Differential]'), 121 121 ))) 122 122 ->appendChild(

+4 -4

src/infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php

reviewed

··· 104 104 $latest = $this->getConduit()->callMethodSynchronous( 105 105 'feed.query', 106 106 array( 107 107 - 'limit'=>1 107 107 + 'limit' => 1, 108 108 )); 109 109 110 110 foreach ($latest as $story) { ··· 127 127 $stories = $this->getConduit()->callMethodSynchronous( 128 128 'feed.query', 129 129 array( 130 130 - 'limit'=>$config_page_size, 131 131 - 'after'=>$chrono_key_cursor, 132 132 - 'view'=>'text' 130 130 + 'limit' => $config_page_size, 131 131 + 'after' => $chrono_key_cursor, 132 132 + 'view' => 'text', 133 133 )); 134 134 135 135 foreach ($stories as $story) {

+1 -1

src/infrastructure/sms/adapter/PhabricatorSMSImplementationTwilioAdapter.php

reviewed

··· 93 93 $prepend = '+1'; 94 94 break; 95 95 } 96 96 - return $prepend . $number; 96 96 + return $prepend.$number; 97 97 } 98 98 99 99 }

+3 -3

src/view/control/AphrontCursorPagerView.php

reviewed

··· 146 146 array( 147 147 'href' => $first_uri, 148 148 ), 149 149 - "\xC2\xAB ". pht('First')); 149 149 + "\xC2\xAB ".pht('First')); 150 150 } 151 151 152 152 $prev_uri = $this->getPrevPageURI(); ··· 156 156 array( 157 157 'href' => $prev_uri, 158 158 ), 159 159 - "\xE2\x80\xB9 " . pht('Prev')); 159 159 + "\xE2\x80\xB9 ".pht('Prev')); 160 160 } 161 161 162 162 $next_uri = $this->getNextPageURI(); ··· 166 166 array( 167 167 'href' => $next_uri, 168 168 ), 169 169 - pht('Next') . " \xE2\x80\xBA"); 169 169 + pht('Next')." \xE2\x80\xBA"); 170 170 } 171 171 172 172 return phutil_tag(

+1 -1

src/view/layout/PhabricatorSourceCodeView.php

reviewed

··· 71 71 } 72 72 73 73 if ($this->canClickHighlight) { 74 74 - $line_uri = $this->uri . '$' . $line_number; 74 74 + $line_uri = $this->uri.'$'.$line_number; 75 75 $line_href = (string) new PhutilURI($line_uri); 76 76 77 77 $tag_number = javelin_tag(