recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove very old "vsDiff" data from commit update / diff extraction pipeline

Summary:
Ref T13276. This was introduced in D2586 to power a "trigger audits when the committed change does not match the reviewed change" feature. It was removed without ceremony in D15939. Broadly, rebases mean that this sort of feature can't really work like this and this approach is inherently unreliable; see also T182.

This property no longer has readers, and is unlikely to get any in the future since my planned pathway for "committed code must match reviewed code, modulo an automated rebase" is automating the rebase via "Land Revision", not comparing the diff text.

Remove this to simplify the flow of data here so that things in T13276 can be fixed more easily.

Test Plan: Grepped for `vsDiff`, no hits.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13276

Differential Revision: https://secure.phabricator.com/D20395

epriestley d02256df 0f9776fb

+1 -11
-6
src/applications/differential/engine/DifferentialDiffExtractionEngine.php
··· 243 243 PhabricatorContentSource $content_source) { 244 244 245 245 $viewer = $this->getViewer(); 246 - $result_data = array(); 247 - 248 246 $new_diff = $this->newDiffFromCommit($commit); 249 247 250 248 $old_diff = $revision->getActiveDiff(); ··· 261 259 $old_diff, 262 260 $new_diff); 263 261 if ($has_changed) { 264 - $result_data['vsDiff'] = $old_diff->getID(); 265 - 266 262 $revision_monogram = $revision->getMonogram(); 267 263 $old_id = $old_diff->getID(); 268 264 $new_id = $new_diff->getID(); ··· 336 332 // lost a race to close the revision. That's perfectly fine, we can 337 333 // just continue normally. 338 334 } 339 - 340 - return $result_data; 341 335 } 342 336 343 337 private function loadConcerningBuilds(DifferentialRevision $revision) {
+1 -5
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
··· 278 278 279 279 $content_source = $this->newContentSource(); 280 280 281 - $update_data = $extraction_engine->updateRevisionWithCommit( 281 + $extraction_engine->updateRevisionWithCommit( 282 282 $revision, 283 283 $commit, 284 284 array( 285 285 $commit_close_xaction, 286 286 ), 287 287 $content_source); 288 - 289 - foreach ($update_data as $key => $value) { 290 - $data->setCommitDetail($key, $value); 291 - } 292 288 } 293 289 } 294 290 }