@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Wrap the feed text rendering stuff with `htmlspecialchars_decode`
Summary: I've only seen this be an issue with PhabricatorBot.
Test Plan: Comment on something with characters that are automatically converted like "<>", and see what the irc bot reports
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley
CC: epriestley, aran
Differential Revision: https://secure.phabricator.com/D8140
authored by
Korvin Szanto
and committed by
epriestley
d02b106d
30b9503b
+10
-2
+5
-1
src/applications/tokens/feed/PhabricatorTokenGivenFeedStory.php
+5
-1
src/applications/tokens/feed/PhabricatorTokenGivenFeedStory.php
···
44
44
45
45
public function renderText() {
46
46
// TODO: This is grotesque; the feed notification handler relies on it.
47
-
return strip_tags(hsprintf('%s', $this->renderView()->render()));
47
+
return htmlspecialchars_decode(
48
+
strip_tags(
49
+
hsprintf(
50
+
'%s',
51
+
$this->renderView()->render())));
48
52
}
49
53
50
54
}
+5
-1
src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php
+5
-1
src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php
···
66
66
67
67
public function renderText() {
68
68
// TODO: This is grotesque; the feed notification handler relies on it.
69
-
return strip_tags(hsprintf('%s', $this->renderView()->render()));
69
+
return htmlspecialchars_decode(
70
+
strip_tags(
71
+
hsprintf(
72
+
'%s',
73
+
$this->renderView()->render())));
70
74
}
71
75
72
76
}