@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make drag-and-drop to upload files work on any Home dashboard, not just "Magic Home"
Summary: Ref T12174. Drag-and-drop-to-upload requires some stuff in the document. Put that stuff on all the content pages (currently: dashboards, magic home), not just the builtin home.
Test Plan:
- Dragged-and-dropped onto a Home dashbboard to upload.
- Viewed, and dragged-and-dropped onto "builtin home" to upload.
- Dragged onto "Edit Menu" for home, no upload.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12174
Differential Revision: https://secure.phabricator.com/D17307
+19
-10
+18
src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php
+18
src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php
···
11
11
return "/home/menu/{$path}";
12
12
}
13
13
14
+
protected function buildItemViewContent(
15
+
PhabricatorProfileMenuItemConfiguration $item) {
16
+
$viewer = $this->getViewer();
17
+
18
+
// Add content to the document so that you can drag-and-drop files onto
19
+
// the home page or any home dashboard to upload them.
20
+
21
+
$upload = id(new PhabricatorGlobalUploadTargetView())
22
+
->setUser($viewer);
23
+
24
+
$content = parent::buildItemViewContent($item);
25
+
26
+
return array(
27
+
$content,
28
+
$upload,
29
+
);
30
+
}
31
+
14
32
protected function getBuiltinProfileItems($object) {
15
33
$viewer = $this->getViewer();
16
34
$items = array();
-9
src/applications/home/view/PHUIHomeView.php
-9
src/applications/home/view/PHUIHomeView.php
···
12
12
}
13
13
14
14
protected function getTagContent() {
15
-
$viewer = $this->getViewer();
16
-
17
-
return array(
18
-
$this->buildMainResponse(),
19
-
id(new PhabricatorGlobalUploadTargetView())->setUser($viewer),
20
-
);
21
-
}
22
-
23
-
private function buildMainResponse() {
24
15
require_celerity_resource('phabricator-dashboard-css');
25
16
$viewer = $this->getViewer();
26
17
+1
-1
src/applications/search/engine/PhabricatorProfileMenuEngine.php
+1
-1
src/applications/search/engine/PhabricatorProfileMenuEngine.php