recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove "Apply Patch" UI field from Differential

Summary: Ref T12026. This simplifies the UI and makes T11114 easier. I plan to integrate this into "Download Raw Diff" in the future.

Test Plan:
- Browsed revisions.
- Grepped for removed class name.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12026

Differential Revision: https://secure.phabricator.com/D17069

epriestley d12856b5 a74d602b

-36
-2
src/__phutil_library_map__.php
··· 351 351 'DifferentialAddCommentView' => 'applications/differential/view/DifferentialAddCommentView.php', 352 352 'DifferentialAdjustmentMapTestCase' => 'applications/differential/storage/__tests__/DifferentialAdjustmentMapTestCase.php', 353 353 'DifferentialAffectedPath' => 'applications/differential/storage/DifferentialAffectedPath.php', 354 - 'DifferentialApplyPatchField' => 'applications/differential/customfield/DifferentialApplyPatchField.php', 355 354 'DifferentialAsanaRepresentationField' => 'applications/differential/customfield/DifferentialAsanaRepresentationField.php', 356 355 'DifferentialAuditorsCommitMessageField' => 'applications/differential/field/DifferentialAuditorsCommitMessageField.php', 357 356 'DifferentialAuditorsField' => 'applications/differential/customfield/DifferentialAuditorsField.php', ··· 4996 4995 'DifferentialAddCommentView' => 'AphrontView', 4997 4996 'DifferentialAdjustmentMapTestCase' => 'PhutilTestCase', 4998 4997 'DifferentialAffectedPath' => 'DifferentialDAO', 4999 - 'DifferentialApplyPatchField' => 'DifferentialCustomField', 5000 4998 'DifferentialAsanaRepresentationField' => 'DifferentialCustomField', 5001 4999 'DifferentialAuditorsCommitMessageField' => 'DifferentialCommitMessageCustomField', 5002 5000 'DifferentialAuditorsField' => 'DifferentialStoredCustomField',
-2
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
··· 58 58 new DifferentialUnitField(), 59 59 new DifferentialRevertPlanField(), 60 60 61 - new DifferentialApplyPatchField(), 62 - 63 61 new DifferentialRevisionIDField(), 64 62 ); 65 63
-32
src/applications/differential/customfield/DifferentialApplyPatchField.php
··· 1 - <?php 2 - 3 - final class DifferentialApplyPatchField 4 - extends DifferentialCustomField { 5 - 6 - public function getFieldKey() { 7 - return 'differential:apply-patch'; 8 - } 9 - 10 - public function getFieldName() { 11 - return pht('Apply Patch'); 12 - } 13 - 14 - public function getFieldDescription() { 15 - return pht('Provides instructions for applying a local patch.'); 16 - } 17 - 18 - public function shouldAppearInPropertyView() { 19 - return true; 20 - } 21 - 22 - public function renderPropertyViewLabel() { 23 - return $this->getFieldName(); 24 - } 25 - 26 - public function renderPropertyViewValue(array $handles) { 27 - $mono = $this->getObject()->getMonogram(); 28 - 29 - return phutil_tag('tt', array(), "arc patch {$mono}"); 30 - } 31 - 32 - }