@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove completely pointless load of every repository when viewing a repository URI
Summary:
See D18176. This query has no effect (other than wasting resources) and the result is unused.
`$repository` already has the URI loaded because we load them unconditionally during request initialization.
Test Plan: Viewed repository URIs.
Subscribers: jmeador
Differential Revision: https://secure.phabricator.com/D19036
+1
-5
+1
-5
src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php
+1
-5
src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php
···
23
23
return new Aphront404Response();
24
24
}
25
25
26
-
// For display, reload the URI by loading it through the repository. This
26
+
// For display, access the URI by loading it through the repository. This
27
27
// may adjust builtin URIs for repository configuration, so we may end up
28
28
// with a different view of builtin URIs than we'd see if we loaded them
29
29
// directly from the database. See T12884.
30
-
$repository_with_uris = id(new PhabricatorRepositoryQuery())
31
-
->setViewer($viewer)
32
-
->needURIs(true)
33
-
->execute();
34
30
35
31
$repository_uris = $repository->getURIs();
36
32
$repository_uris = mpull($repository_uris, null, 'getID');