@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove ReleephRequestException
Summary: This has two use sites and no special logic.
Test Plan: `grep`
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D6783
+2
-7
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
1986
1986
'ReleephRequestCommentController' => 'applications/releeph/controller/request/ReleephRequestCommentController.php',
1987
1987
'ReleephRequestDifferentialCreateController' => 'applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php',
1988
1988
'ReleephRequestEditController' => 'applications/releeph/controller/request/ReleephRequestEditController.php',
1989
-
'ReleephRequestException' => 'applications/releeph/storage/request/exception/ReleephRequestException.php',
1990
1989
'ReleephRequestHeaderListView' => 'applications/releeph/view/request/header/ReleephRequestHeaderListView.php',
1991
1990
'ReleephRequestHeaderView' => 'applications/releeph/view/request/header/ReleephRequestHeaderView.php',
1992
1991
'ReleephRequestIntentsView' => 'applications/releeph/view/request/ReleephRequestIntentsView.php',
···
4187
4186
'ReleephRequestCommentController' => 'ReleephProjectController',
4188
4187
'ReleephRequestDifferentialCreateController' => 'ReleephProjectController',
4189
4188
'ReleephRequestEditController' => 'ReleephProjectController',
4190
-
'ReleephRequestException' => 'Exception',
4191
4189
'ReleephRequestHeaderListView' => 'AphrontView',
4192
4190
'ReleephRequestHeaderView' => 'AphrontView',
4193
4191
'ReleephRequestIntentsView' => 'AphrontView',
+2
-2
src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php
+2
-2
src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php
···
25
25
'arcanistProjectID = %d AND isActive = 1',
26
26
$arc_project->getID());
27
27
if (!$projects) {
28
-
throw new ReleephRequestException(sprintf(
28
+
throw new Exception(sprintf(
29
29
"D%d belongs to the '%s' Arcanist project, ".
30
30
"which is not part of any Releeph project!",
31
31
$this->revision->getID(),
···
36
36
'releephProjectID IN (%Ld) AND isActive = 1',
37
37
mpull($projects, 'getID'));
38
38
if (!$branches) {
39
-
throw new ReleephRequestException(sprintf(
39
+
throw new Exception(sprintf(
40
40
"D%d could be in the Releeph project(s) %s, ".
41
41
"but this project / none of these projects have open branches.",
42
42
$this->revision->getID(),