@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Audit - another partial fix to commit re-parsing bug
Summary: Ref T6350. We build $sql based on whose subscribed. If no one is subscribed, then we have no query to run.
Test Plan: observed one error disappearing from my daemon log. Also, more doing it live.
Reviewers: epriestley, chad
Reviewed By: chad
Subscribers: Korvin, epriestley
Maniphest Tasks: T6350
Differential Revision: https://secure.phabricator.com/D10731
+9
-6
+9
-6
src/applications/feed/PhabricatorFeedStoryPublisher.php
+9
-6
src/applications/feed/PhabricatorFeedStoryPublisher.php
···
164
164
$mark_read);
165
165
}
166
166
167
-
queryfx(
168
-
$conn,
169
-
'INSERT INTO %T (primaryObjectPHID, userPHID, chronologicalKey, hasViewed)
170
-
VALUES %Q',
171
-
$notif->getTableName(),
172
-
implode(', ', $sql));
167
+
if ($sql) {
168
+
queryfx(
169
+
$conn,
170
+
'INSERT INTO %T '.
171
+
'(primaryObjectPHID, userPHID, chronologicalKey, hasViewed) '.
172
+
'VALUES %Q',
173
+
$notif->getTableName(),
174
+
implode(', ', $sql));
175
+
}
173
176
}
174
177
175
178
private function sendNotification($chrono_key, array $subscribed_phids) {