@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

[Redesign] Normalize header policy and object tags

Summary: Ref T8099, This adds a consistent background color to object and policy tags, and highlights them when they deviate from the normal. Still likely worth revamping 'closed' and 'review' state colors.

Test Plan: Review lots of diffs and tasks.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13399

+16 -26
+3 -3
resources/celerity/map.php
··· 7 7 */ 8 8 return array( 9 9 'names' => array( 10 - 'core.pkg.css' => '61e69662', 10 + 'core.pkg.css' => '0ea26c65', 11 11 'core.pkg.js' => 'a590b451', 12 12 'darkconsole.pkg.js' => 'e7393ebb', 13 13 'differential.pkg.css' => 'fe951924', ··· 134 134 'rsrc/css/phui/phui-fontkit.css' => '6790f776', 135 135 'rsrc/css/phui/phui-form-view.css' => 'a0e8f168', 136 136 'rsrc/css/phui/phui-form.css' => '17ce37a9', 137 - 'rsrc/css/phui/phui-header-view.css' => '3d78fd16', 137 + 'rsrc/css/phui/phui-header-view.css' => '541c6cc7', 138 138 'rsrc/css/phui/phui-icon.css' => '88ba9081', 139 139 'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8', 140 140 'rsrc/css/phui/phui-info-panel.css' => '27ea50a1', ··· 777 777 'phui-fontkit-css' => '6790f776', 778 778 'phui-form-css' => '17ce37a9', 779 779 'phui-form-view-css' => 'a0e8f168', 780 - 'phui-header-view-css' => '3d78fd16', 780 + 'phui-header-view-css' => '541c6cc7', 781 781 'phui-icon-view-css' => '88ba9081', 782 782 'phui-image-mask-css' => '5a8b09c8', 783 783 'phui-info-panel-css' => '27ea50a1',
+1 -1
src/applications/differential/constants/DifferentialRevisionStatus.php
··· 68 68 $tag = phutil_tag( 69 69 'span', 70 70 array( 71 - 'class' => 'phui-header-'.$color.' plr', 71 + 'class' => 'phui-header-status phui-header-'.$color, 72 72 ), 73 73 array( 74 74 $img,
+1 -1
src/view/phui/PHUIHeaderView.php
··· 110 110 $tag = phutil_tag( 111 111 'span', 112 112 array( 113 - 'class' => "{$header_class} plr", 113 + 'class' => "phui-header-status {$header_class}", 114 114 ), 115 115 array( 116 116 $img,
+11 -21
webroot/rsrc/css/phui/phui-header-view.css
··· 144 144 color: {$darkbluetext}; 145 145 } 146 146 147 - .policy-header-callout.policy-adjusted { 148 - padding: 0 4px; 147 + .policy-header-callout, 148 + .phui-header-subheader .phui-header-status { 149 + padding: 3px 9px; 149 150 border-radius: 3px; 151 + background: {$lightbluebackground}; 152 + margin-right: 8px; 150 153 } 151 154 152 155 .policy-header-callout.policy-adjusted-weaker { 153 - background: {$lightgreen}; 154 - border: 1px solid {$green}; 156 + background: {$sh-greenbackground}; 155 157 } 156 158 157 159 .policy-header-callout.policy-adjusted-weaker .policy-link, 158 160 .policy-header-callout.policy-adjusted-weaker .phui-icon-view { 159 - color: {$green}; 161 + color: {$sh-greentext}; 160 162 } 161 163 162 164 .policy-header-callout.policy-adjusted-stronger { 163 - background: {$lightred}; 164 - border: 1px solid {$red}; 165 + background: {$sh-redbackground}; 165 166 } 166 167 167 168 .policy-header-callout.policy-adjusted-stronger .policy-link, 168 169 .policy-header-callout.policy-adjusted-stronger .phui-icon-view { 169 - color: {$red}; 170 + color: {$sh-redtext}; 170 171 } 171 172 172 173 .policy-header-callout.policy-adjusted-different { 173 - background: {$lightorange}; 174 - border: 1px solid {$orange}; 174 + background: {$sh-orangebackground}; 175 175 } 176 176 177 177 .policy-header-callout.policy-adjusted-different .policy-link, 178 178 .policy-header-callout.policy-adjusted-different .phui-icon-view { 179 - color: {$orange}; 179 + color: {$sh-orangetext}; 180 180 } 181 181 182 182 .phui-header-subheader .phui-header-status-dark { 183 183 color: {$sh-indigotext}; 184 184 background: {$sh-indigobackground}; 185 185 margin-right: 8px; 186 - padding: 4px 8px; 187 - border-radius: 3px; 188 186 } 189 187 190 188 .phui-header-subheader .phui-header-status-dark .phui-icon-view { ··· 194 192 .phui-header-subheader .phui-header-status-red { 195 193 color: {$sh-redtext}; 196 194 background: {$sh-redbackground}; 197 - margin-right: 8px; 198 - padding: 4px 8px; 199 - border-radius: 3px; 200 - margin-right: 8px; 201 195 } 202 196 203 197 .phui-header-subheader .phui-header-status-green { 204 198 color: {$sh-greentext}; 205 199 background: {$sh-greenbackground}; 206 - margin-right: 8px; 207 - padding: 4px 8px; 208 - border-radius: 3px; 209 - margin-right: 8px; 210 200 } 211 201 212 202 .phui-header-action-links .phui-mobile-menu {