recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

User search: Correct "Name Contains" (nameLike) query constraint description

Summary:
Passing a value for the `nameLike` parameter to `PhabricatorPeopleQuery` does not only search for that substring within usernames but also within realnames.

Closes T16132

Test Plan:
1. Go to http://phorge.localhost/conduit/method/user.search/ and look at the Description for the `nameLike` constraint.
2. Set up a user with a username different from the realname.
3. Go to http://phorge.localhost/people/query/advanced/ and enter a substring of the realname into the `Name Contains` field, still get the user from step 2 listed in the query results.

Reviewers: O1 Blessed Committers, valerio.bozzolan, mainframe98

Reviewed By: O1 Blessed Committers, valerio.bozzolan, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16132

Differential Revision: https://we.phorge.it/D26116

Andre Klapper d29d7989 cdde4a1f

+2 -1
+2 -1
src/applications/people/query/PhabricatorPeopleSearchEngine.php
··· 28 28 ->setLabel(pht('Name Contains')) 29 29 ->setKey('nameLike') 30 30 ->setDescription( 31 - pht('Find users whose usernames contain a substring.')), 31 + pht( 32 + 'Find users whose usernames or real names contain a substring.')), 32 33 id(new PhabricatorSearchThreeStateField()) 33 34 ->setLabel(pht('Administrators')) 34 35 ->setKey('isAdmin')