@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow Owners packages to have arbitrarily long names
Summary:
- Change column type from `sort128` to `sort`.
- Remove `originalName`. This column is unused. Long ago, we used it to generate a `Thread-Topic` header for mail, but just use PHIDs now (the value just needs to be stable for a given object, users normally don't see it).
Test Plan:
- Created a package with a beautifully long name. Magnificent!
- Grepped for `originalName` / `getOriginalName()`, found no Owners hits.
- Verified that there isn't any name-length validation code to remove.
{F4925637}
Reviewers: chad, amckinley
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D17798
+3
-6
+2
resources/sql/autopatches/20170427.owners.01.long.sql
+2
resources/sql/autopatches/20170427.owners.01.long.sql
+1
-6
src/applications/owners/storage/PhabricatorOwnersPackage.php
+1
-6
src/applications/owners/storage/PhabricatorOwnersPackage.php
···
12
12
PhabricatorNgramsInterface {
13
13
14
14
protected $name;
15
-
protected $originalName;
16
15
protected $auditingEnabled;
17
16
protected $autoReview;
18
17
protected $description;
···
105
104
self::CONFIG_TIMESTAMPS => false,
106
105
self::CONFIG_AUX_PHID => true,
107
106
self::CONFIG_COLUMN_SCHEMA => array(
108
-
'name' => 'sort128',
109
-
'originalName' => 'text255',
107
+
'name' => 'sort',
110
108
'description' => 'text',
111
109
'primaryOwnerPHID' => 'phid?',
112
110
'auditingEnabled' => 'bool',
···
137
135
138
136
public function setName($name) {
139
137
$this->name = $name;
140
-
if (!$this->getID()) {
141
-
$this->originalName = $name;
142
-
}
143
138
return $this;
144
139
}
145
140