@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When a project has a custom icon, use that icon to label the project policy in the policy dropown
Summary:
Fixes T8808. Currently, all project use the default ("Briefcase") project icon when they appear in a policy dropdown.
Since project policies are separated out into a "Members of Projects" section of the dropdown anyway, there is no reason not to use the actual project icon, which is often more clear.
Test Plan: {F6849927}
Maniphest Tasks: T8808
Differential Revision: https://secure.phabricator.com/D20799
+4
-2
+4
-2
src/applications/policy/storage/PhabricatorPolicy.php
+4
-2
src/applications/policy/storage/PhabricatorPolicy.php
···
85
85
$phid_type = phid_get_type($policy_identifier);
86
86
switch ($phid_type) {
87
87
case PhabricatorProjectProjectPHIDType::TYPECONST:
88
-
$policy->setType(PhabricatorPolicyType::TYPE_PROJECT);
89
-
$policy->setName($handle->getName());
88
+
$policy
89
+
->setType(PhabricatorPolicyType::TYPE_PROJECT)
90
+
->setName($handle->getName())
91
+
->setIcon($handle->getIcon());
90
92
break;
91
93
case PhabricatorPeopleUserPHIDType::TYPECONST:
92
94
$policy->setType(PhabricatorPolicyType::TYPE_USER);