recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT"

Summary:
Fixes T13307. We currently require "CAN_EDIT" to sign actions, but it's fine to sign a comment with only "CAN_INTERACT".

Since the actions like "Accept Revision" already work like this, the fix is one line.

Test Plan: {F6488135}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13307

Differential Revision: https://secure.phabricator.com/D20574

epriestley d3112392 64a95000

+1
+1
src/applications/auth/engineextension/PhabricatorAuthMFAEditEngineExtension.php
··· 38 38 ->setLabel(pht('MFA')) 39 39 ->setIsFormField(false) 40 40 ->setCommentActionLabel(pht('Sign With MFA')) 41 + ->setCanApplyWithoutEditCapability(true) 41 42 ->setCommentActionOrder(12000) 42 43 ->setActionDescription( 43 44 pht('You will be prompted to provide MFA when you submit.'))