@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make unsubscribing from a project have an effect
Summary:
Fixes T10089. This did work at one point, but was broken by D12868, which got too aggressive about mailing members.
We don't want to send mail to all members by default, only those who are subscribed. The parent implementation of `getMailCC()` handles this for us.
Test Plan:
Joined a project as users A and B. Unsubscribed with B. Made an edit.
Before patch: both A and B got mail. After patch: only A got mail.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10089
Differential Revision: https://secure.phabricator.com/D14955
+3
-6
+3
-6
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+3
-6
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
···
597
597
}
598
598
599
599
protected function getMailTo(PhabricatorLiskDAO $object) {
600
-
return $object->getMemberPHIDs();
601
-
}
602
-
603
-
protected function getMailCC(PhabricatorLiskDAO $object) {
604
-
$all = parent::getMailCC($object);
605
-
return array_diff($all, $object->getMemberPHIDs());
600
+
return array(
601
+
$this->getActingAsPHID(),
602
+
);
606
603
}
607
604
608
605
public function getMailTagsMap() {