@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Maniphest Detail view for mobile.

Summary: I try to access tasks a lot on my phone, but its hard to parse. I'm sure most of this will get tossed with new transactions, but wanted to land it anyways.

Test Plan: Test ticket details on iOS simulator and Chrome.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4619

+64 -57
+49 -49
src/__celerity_resource_map__.php
··· 663 663 ), 664 664 'aphront-panel-view-css' => 665 665 array( 666 - 'uri' => '/res/e4ad41d7/rsrc/css/aphront/panel-view.css', 666 + 'uri' => '/res/789ff5e5/rsrc/css/aphront/panel-view.css', 667 667 'type' => 'css', 668 668 'requires' => 669 669 array( ··· 2337 2337 ), 2338 2338 'maniphest-transaction-detail-css' => 2339 2339 array( 2340 - 'uri' => '/res/24e5862f/rsrc/css/application/maniphest/transaction-detail.css', 2340 + 'uri' => '/res/fb430d3e/rsrc/css/application/maniphest/transaction-detail.css', 2341 2341 'type' => 'css', 2342 2342 'requires' => 2343 2343 array( ··· 2895 2895 ), 2896 2896 'phabricator-transaction-view-css' => 2897 2897 array( 2898 - 'uri' => '/res/731959fb/rsrc/css/aphront/transaction.css', 2898 + 'uri' => '/res/d3599152/rsrc/css/aphront/transaction.css', 2899 2899 'type' => 'css', 2900 2900 'requires' => 2901 2901 array( ··· 3254 3254 ), array( 3255 3255 'packages' => 3256 3256 array( 3257 - '4dff6da8' => 3257 + 'd770a9ec' => 3258 3258 array( 3259 3259 'name' => 'core.pkg.css', 3260 3260 'symbols' => ··· 3298 3298 36 => 'phabricator-object-item-list-view-css', 3299 3299 37 => 'global-drag-and-drop-css', 3300 3300 ), 3301 - 'uri' => '/res/pkg/4dff6da8/core.pkg.css', 3301 + 'uri' => '/res/pkg/d770a9ec/core.pkg.css', 3302 3302 'type' => 'css', 3303 3303 ), 3304 3304 '66dca903' => ··· 3457 3457 'uri' => '/res/pkg/fbeded59/javelin.pkg.js', 3458 3458 'type' => 'js', 3459 3459 ), 3460 - 'fcdf4c24' => 3460 + 'e30a3fa8' => 3461 3461 array( 3462 3462 'name' => 'maniphest.pkg.css', 3463 3463 'symbols' => ··· 3467 3467 2 => 'aphront-attached-file-view-css', 3468 3468 3 => 'phabricator-project-tag-css', 3469 3469 ), 3470 - 'uri' => '/res/pkg/fcdf4c24/maniphest.pkg.css', 3470 + 'uri' => '/res/pkg/e30a3fa8/maniphest.pkg.css', 3471 3471 'type' => 'css', 3472 3472 ), 3473 3473 '7707de41' => ··· 3487 3487 ), 3488 3488 'reverse' => 3489 3489 array( 3490 - 'aphront-attached-file-view-css' => 'fcdf4c24', 3491 - 'aphront-crumbs-view-css' => '4dff6da8', 3492 - 'aphront-dialog-view-css' => '4dff6da8', 3493 - 'aphront-error-view-css' => '4dff6da8', 3494 - 'aphront-form-view-css' => '4dff6da8', 3490 + 'aphront-attached-file-view-css' => 'e30a3fa8', 3491 + 'aphront-crumbs-view-css' => 'd770a9ec', 3492 + 'aphront-dialog-view-css' => 'd770a9ec', 3493 + 'aphront-error-view-css' => 'd770a9ec', 3494 + 'aphront-form-view-css' => 'd770a9ec', 3495 3495 'aphront-headsup-action-list-view-css' => 'ec01d039', 3496 - 'aphront-headsup-view-css' => '4dff6da8', 3497 - 'aphront-list-filter-view-css' => '4dff6da8', 3498 - 'aphront-pager-view-css' => '4dff6da8', 3499 - 'aphront-panel-view-css' => '4dff6da8', 3500 - 'aphront-table-view-css' => '4dff6da8', 3501 - 'aphront-tokenizer-control-css' => '4dff6da8', 3502 - 'aphront-tooltip-css' => '4dff6da8', 3503 - 'aphront-typeahead-control-css' => '4dff6da8', 3496 + 'aphront-headsup-view-css' => 'd770a9ec', 3497 + 'aphront-list-filter-view-css' => 'd770a9ec', 3498 + 'aphront-pager-view-css' => 'd770a9ec', 3499 + 'aphront-panel-view-css' => 'd770a9ec', 3500 + 'aphront-table-view-css' => 'd770a9ec', 3501 + 'aphront-tokenizer-control-css' => 'd770a9ec', 3502 + 'aphront-tooltip-css' => 'd770a9ec', 3503 + 'aphront-typeahead-control-css' => 'd770a9ec', 3504 3504 'differential-changeset-view-css' => 'ec01d039', 3505 3505 'differential-core-view-css' => 'ec01d039', 3506 3506 'differential-inline-comment-editor' => 'ac53d36a', ··· 3514 3514 'differential-table-of-contents-css' => 'ec01d039', 3515 3515 'diffusion-commit-view-css' => 'c8ce2d88', 3516 3516 'diffusion-icons-css' => 'c8ce2d88', 3517 - 'global-drag-and-drop-css' => '4dff6da8', 3517 + 'global-drag-and-drop-css' => 'd770a9ec', 3518 3518 'inline-comment-summary-css' => 'ec01d039', 3519 3519 'javelin-aphlict' => '66dca903', 3520 3520 'javelin-behavior' => 'fbeded59', ··· 3584 3584 'javelin-util' => 'fbeded59', 3585 3585 'javelin-vector' => 'fbeded59', 3586 3586 'javelin-workflow' => 'fbeded59', 3587 - 'lightbox-attachment-css' => '4dff6da8', 3588 - 'maniphest-task-summary-css' => 'fcdf4c24', 3589 - 'maniphest-transaction-detail-css' => 'fcdf4c24', 3587 + 'lightbox-attachment-css' => 'd770a9ec', 3588 + 'maniphest-task-summary-css' => 'e30a3fa8', 3589 + 'maniphest-transaction-detail-css' => 'e30a3fa8', 3590 3590 'phabricator-busy' => '66dca903', 3591 3591 'phabricator-content-source-view-css' => 'ec01d039', 3592 - 'phabricator-core-buttons-css' => '4dff6da8', 3593 - 'phabricator-core-css' => '4dff6da8', 3594 - 'phabricator-crumbs-view-css' => '4dff6da8', 3595 - 'phabricator-directory-css' => '4dff6da8', 3592 + 'phabricator-core-buttons-css' => 'd770a9ec', 3593 + 'phabricator-core-css' => 'd770a9ec', 3594 + 'phabricator-crumbs-view-css' => 'd770a9ec', 3595 + 'phabricator-directory-css' => 'd770a9ec', 3596 3596 'phabricator-drag-and-drop-file-upload' => 'ac53d36a', 3597 3597 'phabricator-dropdown-menu' => '66dca903', 3598 3598 'phabricator-file-upload' => '66dca903', 3599 - 'phabricator-filetree-view-css' => '4dff6da8', 3600 - 'phabricator-flag-css' => '4dff6da8', 3601 - 'phabricator-form-view-css' => '4dff6da8', 3602 - 'phabricator-header-view-css' => '4dff6da8', 3603 - 'phabricator-jump-nav' => '4dff6da8', 3599 + 'phabricator-filetree-view-css' => 'd770a9ec', 3600 + 'phabricator-flag-css' => 'd770a9ec', 3601 + 'phabricator-form-view-css' => 'd770a9ec', 3602 + 'phabricator-header-view-css' => 'd770a9ec', 3603 + 'phabricator-jump-nav' => 'd770a9ec', 3604 3604 'phabricator-keyboard-shortcut' => '66dca903', 3605 3605 'phabricator-keyboard-shortcut-manager' => '66dca903', 3606 - 'phabricator-main-menu-view' => '4dff6da8', 3606 + 'phabricator-main-menu-view' => 'd770a9ec', 3607 3607 'phabricator-menu-item' => '66dca903', 3608 - 'phabricator-nav-view-css' => '4dff6da8', 3608 + 'phabricator-nav-view-css' => 'd770a9ec', 3609 3609 'phabricator-notification' => '66dca903', 3610 - 'phabricator-notification-css' => '4dff6da8', 3611 - 'phabricator-notification-menu-css' => '4dff6da8', 3612 - 'phabricator-object-item-list-view-css' => '4dff6da8', 3610 + 'phabricator-notification-css' => 'd770a9ec', 3611 + 'phabricator-notification-menu-css' => 'd770a9ec', 3612 + 'phabricator-object-item-list-view-css' => 'd770a9ec', 3613 3613 'phabricator-object-selector-css' => 'ec01d039', 3614 3614 'phabricator-paste-file-upload' => '66dca903', 3615 3615 'phabricator-prefab' => '66dca903', 3616 - 'phabricator-project-tag-css' => 'fcdf4c24', 3617 - 'phabricator-remarkup-css' => '4dff6da8', 3616 + 'phabricator-project-tag-css' => 'e30a3fa8', 3617 + 'phabricator-remarkup-css' => 'd770a9ec', 3618 3618 'phabricator-shaped-request' => 'ac53d36a', 3619 - 'phabricator-side-menu-view-css' => '4dff6da8', 3620 - 'phabricator-standard-page-view' => '4dff6da8', 3619 + 'phabricator-side-menu-view-css' => 'd770a9ec', 3620 + 'phabricator-standard-page-view' => 'd770a9ec', 3621 3621 'phabricator-textareautils' => '66dca903', 3622 3622 'phabricator-tooltip' => '66dca903', 3623 - 'phabricator-transaction-view-css' => '4dff6da8', 3624 - 'phabricator-zindex-css' => '4dff6da8', 3625 - 'sprite-apps-large-css' => '4dff6da8', 3626 - 'sprite-gradient-css' => '4dff6da8', 3627 - 'sprite-icon-css' => '4dff6da8', 3628 - 'sprite-menu-css' => '4dff6da8', 3629 - 'syntax-highlighting-css' => '4dff6da8', 3623 + 'phabricator-transaction-view-css' => 'd770a9ec', 3624 + 'phabricator-zindex-css' => 'd770a9ec', 3625 + 'sprite-apps-large-css' => 'd770a9ec', 3626 + 'sprite-gradient-css' => 'd770a9ec', 3627 + 'sprite-icon-css' => 'd770a9ec', 3628 + 'sprite-menu-css' => 'd770a9ec', 3629 + 'syntax-highlighting-css' => 'd770a9ec', 3630 3630 ), 3631 3631 ));
+6 -6
src/applications/maniphest/controller/ManiphestTaskDetailController.php
··· 302 302 'tokenizers' => $tokenizer_map, 303 303 )); 304 304 305 - $comment_panel = new AphrontPanelView(); 306 - $comment_panel->appendChild($comment_form); 307 - $comment_panel->addClass('aphront-panel-accent'); 308 - $comment_panel->setHeader($is_serious ? 'Add Comment' : 'Weigh In'); 305 + $comment_header = id(new PhabricatorHeaderView()) 306 + ->setHeader($is_serious ? pht('Add Comment') : pht('Weigh In')); 309 307 310 308 $preview_panel = 311 309 '<div class="aphront-panel-preview"> 312 310 <div id="transaction-preview"> 313 311 <div class="aphront-panel-preview-loading-text"> 314 - Loading preview... 312 + '.pht('Loading preview...').' 315 313 </div> 316 314 </div> 317 315 </div>'; ··· 346 344 $actions, 347 345 $properties, 348 346 $transaction_view, 349 - $comment_panel, 347 + $comment_header, 348 + $comment_form, 350 349 $preview_panel, 351 350 ), 352 351 array( 353 352 'title' => 'T'.$task->getID().' '.$task->getTitle(), 354 353 'pageObjects' => array($task->getPHID()), 354 + 'device' => true, 355 355 )); 356 356 } 357 357
-1
webroot/rsrc/css/aphront/panel-view.css
··· 83 83 .aphront-panel-preview { 84 84 background: #fbfbfb; 85 85 border-bottom: 1px solid #aaaaaa; 86 - margin: -1em 2em 2em; 87 86 padding: 15px 20px; 88 87 } 89 88
+4
webroot/rsrc/css/aphront/transaction.css
··· 16 16 margin-left: 54px; 17 17 } 18 18 19 + .device-phone .phabricator-transaction-detail { 20 + margin: 0; 21 + } 22 + 19 23 .phabricator-transaction-header { 20 24 background: #f3f3f3; 21 25 padding: 4px 1em;
+5 -1
webroot/rsrc/css/application/maniphest/transaction-detail.css
··· 3 3 */ 4 4 5 5 .maniphest-transaction-list-view { 6 - padding: 0 2em; 6 + padding: 0 20px;; 7 + } 8 + 9 + .device-phone .maniphest-transaction-list-view { 10 + padding: 0 10px; 7 11 } 8 12 9 13 .maniphest-transaction-list-view .anchor-target {