@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove unused drag and drop Conpherence code

Summary: Ref T11730. Removes unused code since this is now it's own page.

Test Plan: rebuild maps, grep for javelin code, classnames

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T11730

Differential Revision: https://secure.phabricator.com/D16700

+1 -91
+1 -10
resources/celerity/map.php
··· 8 8 return array( 9 9 'names' => array( 10 10 'conpherence.pkg.css' => '4601645d', 11 - 'conpherence.pkg.js' => '11f3e07e', 11 + 'conpherence.pkg.js' => '44dd69f5', 12 12 'core.pkg.css' => '7ca260a3', 13 13 'core.pkg.js' => '30185d95', 14 14 'darkconsole.pkg.js' => 'e7393ebb', ··· 437 437 'rsrc/js/application/calendar/behavior-recurring-edit.js' => '5f1c4d5f', 438 438 'rsrc/js/application/config/behavior-reorder-fields.js' => 'b6993408', 439 439 'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '01774ab2', 440 - 'rsrc/js/application/conpherence/behavior-drag-and-drop-photo.js' => 'cf86d16a', 441 440 'rsrc/js/application/conpherence/behavior-durable-column.js' => 'c5238acb', 442 441 'rsrc/js/application/conpherence/behavior-menu.js' => '9eb55204', 443 442 'rsrc/js/application/conpherence/behavior-participant-pane.js' => '8604caa8', ··· 665 664 'javelin-behavior-choose-control' => '327a00d1', 666 665 'javelin-behavior-comment-actions' => '0300eae6', 667 666 'javelin-behavior-config-reorder-fields' => 'b6993408', 668 - 'javelin-behavior-conpherence-drag-and-drop-photo' => 'cf86d16a', 669 667 'javelin-behavior-conpherence-menu' => '9eb55204', 670 668 'javelin-behavior-conpherence-participant-pane' => '8604caa8', 671 669 'javelin-behavior-conpherence-pontificate' => 'f2e58483', ··· 2010 2008 'javelin-util', 2011 2009 'phabricator-notification-css', 2012 2010 ), 2013 - 'cf86d16a' => array( 2014 - 'javelin-behavior', 2015 - 'javelin-dom', 2016 - 'javelin-workflow', 2017 - 'phabricator-drag-and-drop-file-upload', 2018 - ), 2019 2011 'cfd23f37' => array( 2020 2012 'javelin-install', 2021 2013 'javelin-util', ··· 2305 2297 'conpherence-header-pane-css', 2306 2298 ), 2307 2299 'conpherence.pkg.js' => array( 2308 - 'javelin-behavior-conpherence-drag-and-drop-photo', 2309 2300 'javelin-behavior-conpherence-menu', 2310 2301 'javelin-behavior-conpherence-participant-pane', 2311 2302 'javelin-behavior-conpherence-pontificate',
-1
resources/celerity/packages.php
··· 162 162 'conpherence-header-pane-css', 163 163 ), 164 164 'conpherence.pkg.js' => array( 165 - 'javelin-behavior-conpherence-drag-and-drop-photo', 166 165 'javelin-behavior-conpherence-menu', 167 166 'javelin-behavior-conpherence-participant-pane', 168 167 'javelin-behavior-conpherence-pontificate',
-2
src/__phutil_library_map__.php
··· 291 291 'ConpherenceDAO' => 'applications/conpherence/storage/ConpherenceDAO.php', 292 292 'ConpherenceDurableColumnView' => 'applications/conpherence/view/ConpherenceDurableColumnView.php', 293 293 'ConpherenceEditor' => 'applications/conpherence/editor/ConpherenceEditor.php', 294 - 'ConpherenceFormDragAndDropUploadControl' => 'applications/conpherence/view/ConpherenceFormDragAndDropUploadControl.php', 295 294 'ConpherenceFulltextQuery' => 'applications/conpherence/query/ConpherenceFulltextQuery.php', 296 295 'ConpherenceIndex' => 'applications/conpherence/storage/ConpherenceIndex.php', 297 296 'ConpherenceLayoutView' => 'applications/conpherence/view/ConpherenceLayoutView.php', ··· 4808 4807 'ConpherenceDAO' => 'PhabricatorLiskDAO', 4809 4808 'ConpherenceDurableColumnView' => 'AphrontTagView', 4810 4809 'ConpherenceEditor' => 'PhabricatorApplicationTransactionEditor', 4811 - 'ConpherenceFormDragAndDropUploadControl' => 'AphrontFormControl', 4812 4810 'ConpherenceFulltextQuery' => 'PhabricatorOffsetPagedQuery', 4813 4811 'ConpherenceIndex' => 'ConpherenceDAO', 4814 4812 'ConpherenceLayoutView' => 'AphrontTagView',
-40
src/applications/conpherence/view/ConpherenceFormDragAndDropUploadControl.php
··· 1 - <?php 2 - 3 - final class ConpherenceFormDragAndDropUploadControl extends AphrontFormControl { 4 - 5 - private $dropID; 6 - 7 - public function setDropID($drop_id) { 8 - $this->dropID = $drop_id; 9 - return $this; 10 - } 11 - public function getDropID() { 12 - return $this->dropID; 13 - } 14 - 15 - protected function getCustomControlClass() { 16 - return null; 17 - } 18 - 19 - protected function renderInput() { 20 - 21 - $drop_id = celerity_generate_unique_node_id(); 22 - Javelin::initBehavior('conpherence-drag-and-drop-photo', 23 - array( 24 - 'target' => $drop_id, 25 - 'form_pane' => 'conpherence-form', 26 - 'upload_uri' => '/file/dropupload/', 27 - 'activated_class' => 'conpherence-dialogue-upload-photo', 28 - )); 29 - require_celerity_resource('conpherence-update-css'); 30 - 31 - return phutil_tag( 32 - 'div', 33 - array( 34 - 'id' => $drop_id, 35 - 'class' => 'conpherence-dialogue-drag-photo', 36 - ), 37 - pht('Drag and drop an image here to upload it.')); 38 - } 39 - 40 - }
-38
webroot/rsrc/js/application/conpherence/behavior-drag-and-drop-photo.js
··· 1 - /** 2 - * @provides javelin-behavior-conpherence-drag-and-drop-photo 3 - * @requires javelin-behavior 4 - * javelin-dom 5 - * javelin-workflow 6 - * phabricator-drag-and-drop-file-upload 7 - */ 8 - 9 - JX.behavior('conpherence-drag-and-drop-photo', function(config) { 10 - 11 - var target = JX.$(config.target); 12 - var form_pane = JX.$(config.form_pane); 13 - 14 - function onupload(f) { 15 - var data = { 16 - 'file_id' : f.getID(), 17 - 'action' : 'metadata' 18 - }; 19 - 20 - var form = JX.DOM.find(form_pane, 'form'); 21 - var workflow = JX.Workflow.newFromForm(form, data); 22 - workflow.start(); 23 - } 24 - 25 - if (JX.PhabricatorDragAndDropFileUpload.isSupported()) { 26 - var drop = new JX.PhabricatorDragAndDropFileUpload(target) 27 - .setURI(config.upload_uri); 28 - drop.listen('didBeginDrag', function() { 29 - JX.DOM.alterClass(target, config.activated_class, true); 30 - }); 31 - drop.listen('didEndDrag', function() { 32 - JX.DOM.alterClass(target, config.activated_class, false); 33 - }); 34 - drop.listen('didUpload', onupload); 35 - drop.start(); 36 - } 37 - 38 - });