@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Improve diffusion readme layout
Summary: Uses more standard objects and more padding for reading. Removes the ToC, which is visually broken anyways.
Test Plan: Review a README.md in a local repository.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D17752
+9
-18
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
72
72
'rsrc/css/application/differential/revision-list.css' => 'f3c47d33',
73
73
'rsrc/css/application/differential/table-of-contents.css' => 'ae4b7a55',
74
74
'rsrc/css/application/diffusion/diffusion-icons.css' => 'a6a1e2ba',
75
-
'rsrc/css/application/diffusion/diffusion-readme.css' => '297373eb',
75
+
'rsrc/css/application/diffusion/diffusion-readme.css' => '18bd3910',
76
76
'rsrc/css/application/diffusion/diffusion-source.css' => '750add59',
77
77
'rsrc/css/application/feed/feed.css' => 'ecd4ec57',
78
78
'rsrc/css/application/files/global-drag-and-drop.css' => '5c1b47c2',
···
579
579
'differential-revision-list-css' => 'f3c47d33',
580
580
'differential-table-of-contents-css' => 'ae4b7a55',
581
581
'diffusion-icons-css' => 'a6a1e2ba',
582
-
'diffusion-readme-css' => '297373eb',
582
+
'diffusion-readme-css' => '18bd3910',
583
583
'diffusion-source-css' => '750add59',
584
584
'diviner-shared-css' => '896f1d43',
585
585
'font-fontawesome' => 'e838e088',
+2
-16
src/applications/diffusion/view/DiffusionReadmeView.php
+2
-16
src/applications/diffusion/view/DiffusionReadmeView.php
···
73
73
->getOutput($markup_object, $markup_field);
74
74
75
75
$engine = $markup_object->newMarkupEngine($markup_field);
76
-
$toc = PhutilRemarkupHeaderBlockRule::renderTableOfContents($engine);
77
-
if ($toc) {
78
-
$toc = phutil_tag_div(
79
-
'phabricator-remarkup-toc',
80
-
array(
81
-
phutil_tag_div(
82
-
'phabricator-remarkup-toc-header',
83
-
pht('Table of Contents')),
84
-
$toc,
85
-
));
86
-
$content = array($toc, $content);
87
-
}
88
76
89
77
$readme_content = $content;
90
78
$class = null;
···
106
94
}
107
95
108
96
$readme_content = phutil_tag_div($class, $readme_content);
109
-
$header = id(new PHUIHeaderView())
110
-
->setHeader($readme_name);
111
-
112
97
$document = id(new PHUIDocumentViewPro())
113
98
->setFluid(true)
114
99
->appendChild($readme_content);
115
100
116
101
return id(new PHUIObjectBoxView())
117
-
->setHeader($header)
102
+
->setHeaderText($readme_name)
103
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
118
104
->appendChild($document)
119
105
->addClass('diffusion-readme-view');
120
106
}