@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Restore "Land Revision" action to UI
Summary: This was accidentally caught in the crossfire in D18150. This is stable enough to formalize instead of adding with an event hook.
Test Plan: Looked at a candidate revision, saw "Land Revision" appear in UI again.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D18154
+23
+23
src/applications/differential/controller/DifferentialRevisionViewController.php
+23
src/applications/differential/controller/DifferentialRevisionViewController.php
···
615
615
$curtain->addAction($relationship_submenu);
616
616
}
617
617
618
+
$repository = $revision->getRepository();
619
+
if ($repository && $repository->canPerformAutomation()) {
620
+
$revision_id = $revision->getID();
621
+
622
+
$op = new DrydockLandRepositoryOperation();
623
+
$barrier = $op->getBarrierToLanding($viewer, $revision);
624
+
625
+
if ($barrier) {
626
+
$can_land = false;
627
+
} else {
628
+
$can_land = true;
629
+
}
630
+
631
+
$action = id(new PhabricatorActionView())
632
+
->setName(pht('Land Revision'))
633
+
->setIcon('fa-fighter-jet')
634
+
->setHref("/differential/revision/operation/{$revision_id}/")
635
+
->setWorkflow(true)
636
+
->setDisabled(!$can_land);
637
+
638
+
$curtain->addAction($action);
639
+
}
640
+
618
641
return $curtain;
619
642
}
620
643