Fix setup check for gzip request mangling being sent as GET

@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge

phorge phabricator

fork

Summary:
Certain web servers (or cache layers such as Varnish) strip the body
of GET requests, resulting in the setup check failing when it would
otherwise function normally if a request is sent as POST.

Test Plan:
Phorge will no-longer mark the test as failing due to the body of a GET request being dropped.
As per RFC7231, certain implementations of HTTP/1.1 may reject the request or drop the payload
due to a previous revision of the spec where the body was supposed to be ignored (RFC2616, section 4.3)

Reviewers: O1 Blessed Committers, 20after4, speck, avivey

Reviewed By: O1 Blessed Committers, 20after4, speck, avivey

Subscribers: speck, 20after4, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25566

Katie 2 years ago d4af32c1 ba835fe0

1 changed file

expand all

src

applications

config

check

PhabricatorWebServerSetupCheck.php

src/applications/config/check/PhabricatorWebServerSetupCheck.php

··· 58 58 $gzip_future = id(new HTTPSFuture($base_uri)) 59 59 ->addHeader('X-Setup-SelfCheck', 1) 60 60 ->addHeader('Content-Encoding', 'gzip') 61 + ->setMethod('POST') 61 62 ->setTimeout(5) 62 63 ->setData($gzip_compressed); 63 64

Configure Feed

Configure Feed