@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix offset-without-limit case in Policy query
Summary: Apparently I am not qualified to do basic math.
Test Plan: Unit test.
Reviewers: vrana
Reviewed By: vrana
CC: aran
Differential Revision: https://secure.phabricator.com/D3218
+10
-2
+5
-1
src/applications/policy/__tests__/PhabricatorPolicyTestCase.php
+5
-1
src/applications/policy/__tests__/PhabricatorPolicyTestCase.php
···
133
133
2,
134
134
count($query->setLimit(3)->setOffset(1)->execute()),
135
135
'Offsets work correctly.');
136
+
137
+
$this->assertEqual(
138
+
2,
139
+
count($query->setLimit(0)->setOffset(1)->execute()),
140
+
'Offset with no limit works.');
136
141
}
137
142
138
143
···
163
168
count($query->setLimit(3)->setOffset(4)->execute()),
164
169
'Limit + offset work.');
165
170
}
166
-
167
171
168
172
169
173
/**
+5
-1
src/infrastructure/query/policy/PhabricatorPolicyQuery.php
+5
-1
src/infrastructure/query/policy/PhabricatorPolicyQuery.php