Continue after rejecting commits from a commit query

@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge

phorge phabricator

fork

Summary: Fixes T6880. If matching commits have no visible/loadable repository, we shouldn't keep going forward in the loop.

Test Plan: Havne't built a repro locally yet so not 100% sure this fixes it.

Reviewers: btrahan, mbishopim3, fabe

Reviewed By: mbishopim3, fabe

Subscribers: mbishopim3, epriestley

Maniphest Tasks: T6880

Differential Revision: https://secure.phabricator.com/D11251

epriestley 11 years ago d4f992d2 f2e87aad

1 changed file

expand all

src

applications

diffusion

query

DiffusionCommitQuery.php

src/applications/diffusion/query/DiffusionCommitQuery.php

··· 192 192 $commit->attachRepository($repo); 193 193 } else { 194 194 unset($commits[$key]); 195 + continue; 195 196 } 196 197 197 198 // Build the identifierMap

Configure Feed

Configure Feed