@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Maniphest status change previews
Summary: See IRC. This will be obsoleted by ApplicationTransactions eventually, but fix issues with stauts change previews for now. Specifically, if you select "Reopen Task", it incorrectly previews as "x created this task" because the old state is not set correctly.
Test Plan: Selected "Reopen Task", saw a preview with the correct language.
Reviewers: chad, btrahan
Reviewed By: chad
CC: aran
Differential Revision: https://secure.phabricator.com/D8094
+5
+5
src/applications/maniphest/controller/ManiphestTransactionPreviewController.php
+5
src/applications/maniphest/controller/ManiphestTransactionPreviewController.php
···
95
95
$transaction->setOldValue($task->getProjectPHIDs());
96
96
$transaction->setNewValue($value);
97
97
break;
98
+
case ManiphestTransaction::TYPE_STATUS:
99
+
$phids = array();
100
+
$transaction->setOldvalue($task->getStatus());
101
+
$transaction->setNewValue($value);
102
+
break;
98
103
default:
99
104
$phids = array();
100
105
$transaction->setNewValue($value);