@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Move Conpherence when warning is present
Summary: Turns out only Conpherence/Durable Column still have issues. Workboards is OK. Simple 2 new CSS classes and punt the issue down the road.
Test Plan: Test Workboards, Conpherence, Durable Column with a setup check issue.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12394
+18
-7
+4
-4
resources/celerity/map.php
+4
-4
resources/celerity/map.php
···
44
44
'rsrc/css/application/config/config-welcome.css' => '6abd79be',
45
45
'rsrc/css/application/config/setup-issue.css' => '22270af2',
46
46
'rsrc/css/application/config/unhandled-exception.css' => '37d4f9a2',
47
-
'rsrc/css/application/conpherence/durable-column.css' => 'caa12d4a',
48
-
'rsrc/css/application/conpherence/menu.css' => '7c900089',
47
+
'rsrc/css/application/conpherence/durable-column.css' => 'f0c208ac',
48
+
'rsrc/css/application/conpherence/menu.css' => 'f389e048',
49
49
'rsrc/css/application/conpherence/message-pane.css' => 'e44b667b',
50
50
'rsrc/css/application/conpherence/notification.css' => '04a6e10a',
51
51
'rsrc/css/application/conpherence/update.css' => '1099a660',
···
515
515
'changeset-view-manager' => '58562350',
516
516
'config-options-css' => '7fedf08b',
517
517
'config-welcome-css' => '6abd79be',
518
-
'conpherence-durable-column-view' => 'caa12d4a',
519
-
'conpherence-menu-css' => '7c900089',
518
+
'conpherence-durable-column-view' => 'f0c208ac',
519
+
'conpherence-menu-css' => 'f389e048',
520
520
'conpherence-message-pane-css' => 'e44b667b',
521
521
'conpherence-notification-css' => '04a6e10a',
522
522
'conpherence-thread-manager' => '0a5192c4',
+6
-3
src/view/page/PhabricatorStandardPageView.php
+6
-3
src/view/page/PhabricatorStandardPageView.php
···
348
348
$header_chrome = $this->menuContent;
349
349
}
350
350
351
+
$classes = array();
352
+
$classes[] = 'main-page-frame';
351
353
$developer_warning = null;
352
354
if (PhabricatorEnv::getEnvConfig('phabricator.developer-mode') &&
353
355
DarkConsoleErrorLogPluginAPI::getErrors()) {
···
363
365
if ($user && $user->getIsAdmin()) {
364
366
$open = PhabricatorSetupCheck::getOpenSetupIssueKeys();
365
367
if ($open) {
368
+
$classes[] = 'page-has-warning';
366
369
$setup_warning = phutil_tag_div(
367
370
'setup-warning-callout',
368
371
phutil_tag(
···
389
392
'class' => 'phabricator-standard-page',
390
393
),
391
394
array(
392
-
$developer_warning,
393
-
$setup_warning,
394
395
$header_chrome,
395
396
phutil_tag(
396
397
'div',
···
418
419
return phutil_tag(
419
420
'div',
420
421
array(
421
-
'class' => 'main-page-frame',
422
+
'class' => implode(' ', $classes),
422
423
),
423
424
array(
425
+
$developer_warning,
426
+
$setup_warning,
424
427
$main_page,
425
428
$durable_column,
426
429
));