@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make hashtags at the end of bolded text render properly

Summary: Fixes T10096. The `**` was being parsed as part of the hashtag, so `**#asdf**` interpreted `#asdf**` as a hashtag.

Test Plan: Unit test; bolded stuff with hashy contents.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10096

Differential Revision: https://secure.phabricator.com/D15006

+11 -1
+1 -1
src/applications/project/remarkup/ProjectRemarkupRule.php
··· 32 32 // controlling and these names should parse correctly. 33 33 34 34 // These characters may never appear anywhere in a hashtag. 35 - $never = '\s?!,:;{}#\\(\\)"\''; 35 + $never = '\s?!,:;{}#\\(\\)"\'\\*/~'; 36 36 37 37 // These characters may not appear at the edge of the string. 38 38 $never_edge = '.';
+10
src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php
··· 125 125 ), 126 126 ), 127 127 128 + '**#orbital**' => array( 129 + 'embed' => array(), 130 + 'ref' => array( 131 + array( 132 + 'offset' => 3, 133 + 'id' => 'orbital', 134 + ), 135 + ), 136 + ), 137 + 128 138 ); 129 139 130 140 foreach ($cases as $input => $expect) {