@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "isUnparsed" flag from commits
Summary: The new "importStatus" property provides a much stronger and more consistent version of this flag. The only callsite was removed by D7452.
Test Plan: Used `grep` to check for callsites and found none.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D7453
+2
-13
+2
-3
src/applications/diffusion/query/DiffusionQuery.php
+2
-3
src/applications/diffusion/query/DiffusionQuery.php
···
99
99
$commits = mpull($commits, null, 'getCommitIdentifier');
100
100
101
101
// Build empty commit objects for every commit, so we can show unparsed
102
-
// commits in history views as "unparsed" instead of not showing them. This
103
-
// makes the process of importing and parsing commits much clearer to the
102
+
// commits in history views (as "Importing") instead of not showing them.
103
+
// This makes the process of importing and parsing commits clearer to the
104
104
// user.
105
105
106
106
$commit_list = array();
···
110
110
$commit_obj = new PhabricatorRepositoryCommit();
111
111
$commit_obj->setRepositoryID($repository->getID());
112
112
$commit_obj->setCommitIdentifier($identifier);
113
-
$commit_obj->setIsUnparsed(true);
114
113
$commit_obj->makeEphemeral();
115
114
}
116
115
$commit_list[$identifier] = $commit_obj;
-10
src/applications/repository/storage/PhabricatorRepositoryCommit.php
-10
src/applications/repository/storage/PhabricatorRepositoryCommit.php
···
25
25
26
26
private $commitData = self::ATTACHABLE;
27
27
private $audits;
28
-
private $isUnparsed;
29
28
private $repository = self::ATTACHABLE;
30
29
31
30
public function attachRepository(PhabricatorRepository $repository) {
···
35
34
36
35
public function getRepository() {
37
36
return $this->assertAttached($this->repository);
38
-
}
39
-
40
-
public function setIsUnparsed($is_unparsed) {
41
-
$this->isUnparsed = $is_unparsed;
42
-
return $this;
43
-
}
44
-
45
-
public function getIsUnparsed() {
46
-
return $this->isUnparsed;
47
37
}
48
38
49
39
public function isImported() {